github-starred/libxlsxwriter

Fork 0

mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00

[GH-ISSUE #1] optimize file does not get closed #1

New issue

Closed

opened 2026-05-05 11:22:52 -06:00 by gitea-mirror · 7 comments

gitea-mirror commented

2026-05-05 11:22:52 -06:00

Owner

Originally created by @LaurinStrelow on GitHub (Feb 18, 2015).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/1

Originally assigned to: @jmcnamara on GitHub.

Hi,

i think i found a bug. When using the the constant memory mode, the worksheet creates temporary files, as i can see this that files never get closed. After creating a large amount of worksheets (on iOS about 300), the system does not create new tempfiles and returns null instead, because there are too many (temp) files open.

Originally created by @LaurinStrelow on GitHub (Feb 18, 2015). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/1 Originally assigned to: @jmcnamara on GitHub. Hi, i think i found a bug. When using the the constant memory mode, the worksheet creates temporary files, as i can see this that files never get closed. After creating a large amount of worksheets (on iOS about 300), the system does not create new tempfiles and returns null instead, because there are too many (temp) files open.

gitea-mirror

2026-05-05 11:22:52 -06:00

closed this issue
added the
feature request
label

gitea-mirror commented

2026-05-05 11:22:58 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 18, 2015):

Hi,

The temp files aren't closed while the calling program is running since they may still be required for writing.

The Python version of the module has an undocumented facility to allow the user to close and if necessary re-open the temp files. This was to workaround a similar open file limit on Windows.

I'll look at adding something similar to libxlsxwriter.

John

@jmcnamara commented on GitHub (Feb 18, 2015): Hi, The temp files aren't closed while the calling program is running since they may still be required for writing. The [Python version of the module](https://github.com/jmcnamara/XlsxWriter) has an undocumented facility to allow the user to close and if necessary re-open the temp files. This was to workaround a similar open file limit on Windows. I'll look at adding something similar to libxlsxwriter. John

gitea-mirror commented

2026-05-05 11:23:00 -06:00

Author

Owner

@LaurinStrelow commented on GitHub (Feb 18, 2015):

This sounds as a good solution. However at the moment the optimize files never get closed, even if the workbook gets closed or the worksheet freed and the file is not needed anymore.

@LaurinStrelow commented on GitHub (Feb 18, 2015): This sounds as a good solution. However at the moment the optimize files never get closed, even if the workbook gets closed or the worksheet freed and the file is not needed anymore.

gitea-mirror commented

2026-05-05 11:23:05 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 19, 2015):

However at the moment the optimize files never get closed, even if the workbook gets closed or the worksheet freed and the file is not needed anymore.

Yes. There is that issue as well. I'll fix it in the next few days.

Is that the issue that you are having or are you also trying to generate a workbook with > 300 worksheets?

John

@jmcnamara commented on GitHub (Feb 19, 2015): > However at the moment the optimize files never get closed, even if the workbook gets closed or the worksheet freed and the file is not needed anymore. Yes. There is that issue as well. I'll fix it in the next few days. Is that the issue that you are having or are you also trying to generate a workbook with > 300 worksheets? John

gitea-mirror commented

2026-05-05 11:23:09 -06:00

Author

Owner

@LaurinStrelow commented on GitHub (Feb 19, 2015):

Yes this was the issue i have. I make two workbooks with about 200 worksheets and the second workbook won't complete. But i think it is better to have the possibility to close the file and won't get near the file limit anytime later, if more worksheets are needed.

@LaurinStrelow commented on GitHub (Feb 19, 2015): Yes this was the issue i have. I make two workbooks with about 200 worksheets and the second workbook won't complete. But i think it is better to have the possibility to close the file and won't get near the file limit anytime later, if more worksheets are needed.

gitea-mirror commented

2026-05-05 11:23:12 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 23, 2015):

Test case:

#include "xlsxwriter.h"

int main() {
    int i;
    lxw_workbook  *workbook;
    lxw_worksheet *worksheet;
    lxw_workbook_options options = {.constant_memory = 1};

    for (i = 0; i <= 5000; i++) {
        printf("File = %d\n", i);

        workbook  = new_workbook_opt("test.xlsx", &options);
        worksheet = workbook_add_worksheet(workbook, NULL);

        worksheet_write_string(worksheet, 0, 0, "Hello", NULL);
        worksheet_write_number(worksheet, 1, 0, 123, NULL);

        workbook_close(workbook);
    }

    return 0;
}

@jmcnamara commented on GitHub (Feb 23, 2015): Test case: ``` c #include "xlsxwriter.h" int main() { int i; lxw_workbook *workbook; lxw_worksheet *worksheet; lxw_workbook_options options = {.constant_memory = 1}; for (i = 0; i <= 5000; i++) { printf("File = %d\n", i); workbook = new_workbook_opt("test.xlsx", &options); worksheet = workbook_add_worksheet(workbook, NULL); worksheet_write_string(worksheet, 0, 0, "Hello", NULL); worksheet_write_number(worksheet, 1, 0, 123, NULL); workbook_close(workbook); } return 0; } ```

gitea-mirror commented

2026-05-05 11:23:14 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 23, 2015):

Hi,

I've pushed a fix to master for the tmpfile issue in constant_memory mode. You can try it when you get a chance.

You should open a second, feature request, issue for the extension to open/close the tempfiles during the life of the workbook, if you need that feature.

P.S. For iOS did you have to use downgrade the version of the zlib libraries as shown here?

John

@jmcnamara commented on GitHub (Feb 23, 2015): Hi, I've pushed a fix to master for the tmpfile issue in `constant_memory mode`. You can try it when you get a chance. You should open a second, feature request, issue for the extension to open/close the tempfiles during the life of the workbook, if you need that feature. P.S. For iOS did you have to use downgrade the version of the zlib libraries as shown [here](http://kvurd.com/blog/building-libxlsxwriter-for-ios/)? John

gitea-mirror commented

2026-05-05 11:23:15 -06:00

Author

Owner

@LaurinStrelow commented on GitHub (Feb 24, 2015):

Hi,

thank you! This solves my issue. I will open another issue for the feature request.
I did not had to downgrade the zlib. The app has already mailcore installed via cocoapods, their binary includes minizip. Therefore i did not need to install minizip or take care of zlib. They are using the preinstalled library. However i needed to replace the zipOpenNewFileInZip4_64 with zipOpenNewFileInZip2 to get the linking done. This is sadly the only possibility i have.

@LaurinStrelow commented on GitHub (Feb 24, 2015): Hi, thank you! This solves my issue. I will open another issue for the feature request. I did not had to downgrade the zlib. The app has already mailcore installed via cocoapods, their binary includes minizip. Therefore i did not need to install minizip or take care of zlib. They are using the preinstalled library. However i needed to replace the `zipOpenNewFileInZip4_64` with `zipOpenNewFileInZip2` to get the linking done. This is sadly the only possibility i have.

gitea-mirror referenced this issue

2026-05-05 12:08:08 -06:00

[GH-ISSUE #388] image_buffer error in version 1.1.5 #310

gitea-mirror referenced this issue

2026-05-05 12:15:36 -06:00

[PR #143] [CLOSED] Merge pull request #1 from jmcnamara/master #425

gitea-mirror referenced this issue

2026-05-05 12:15:59 -06:00

[PR #213] [MERGED] Fix compile-time warnings with strict prototypes enabled. Fixes #208 #442

gitea-mirror referenced this issue

2026-05-05 12:17:28 -06:00

[PR #448] [CLOSED] Fix error: "C++ style comments are not allowed in ISO C90" make compilation on MSYS2 MinGW64 #495