[PR #213] [MERGED] Fix compile-time warnings with strict prototypes enabled. Fixes #208 #442

New issue

Closed

opened 2026-05-05 12:15:59 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:59 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/213
Author: @evanmiller
Created: 1/10/2019
Status: ✅ Merged
Merged: 1/30/2019
Merged by: @jmcnamara

Base: master ← Head: strict-prototypes

📝 Commits (5)

d4cf758 Fix compile-time warnings with strict prototypes enabled. Fixes #208
cd8530f Fix compile time warnings with strict prototypes enabled
b3de0b0 fix failing test
2ee7248 Update parameters in source files too
8a9e3c6 Merge pull request #1 from jjochen/fix/evanmiller/strict-prototypes

📊 Changes

22 files changed (+22 additions, -22 deletions)

View changed files

📝 include/xlsxwriter/app.h (+1 -1)
📝 include/xlsxwriter/chartsheet.h (+1 -1)
📝 include/xlsxwriter/content_types.h (+1 -1)
📝 include/xlsxwriter/core.h (+1 -1)
📝 include/xlsxwriter/custom.h (+1 -1)
📝 include/xlsxwriter/drawing.h (+1 -1)
📝 include/xlsxwriter/format.h (+1 -1)
📝 include/xlsxwriter/relationships.h (+1 -1)
📝 include/xlsxwriter/shared_strings.h (+1 -1)
📝 include/xlsxwriter/styles.h (+1 -1)
📝 include/xlsxwriter/theme.h (+1 -1)
📝 src/app.c (+1 -1)
📝 src/content_types.c (+1 -1)
📝 src/core.c (+1 -1)
📝 src/custom.c (+1 -1)
📝 src/drawing.c (+1 -1)
📝 src/format.c (+1 -1)
📝 src/relationships.c (+1 -1)
📝 src/shared_strings.c (+1 -1)
📝 src/styles.c (+1 -1)

...and 2 more files

📄 Description

The C standard (and -Wstrict-prototypes) requires that functions which take no arguments be declared as foobar(void) instead of foobar().

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/213 **Author:** [@evanmiller](https://github.com/evanmiller) **Created:** 1/10/2019 **Status:** ✅ Merged **Merged:** 1/30/2019 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `strict-prototypes` --- ### 📝 Commits (5) - [`d4cf758`](https://github.com/jmcnamara/libxlsxwriter/commit/d4cf7581fac1088ba749a5a116e23b55fe8ccef8) Fix compile-time warnings with strict prototypes enabled. Fixes #208 - [`cd8530f`](https://github.com/jmcnamara/libxlsxwriter/commit/cd8530f4a590f3fc468f977d0d3811fe222c968f) Fix compile time warnings with strict prototypes enabled - [`b3de0b0`](https://github.com/jmcnamara/libxlsxwriter/commit/b3de0b04b07dbb6dc66c9b8a6df1e7436d583b99) fix failing test - [`2ee7248`](https://github.com/jmcnamara/libxlsxwriter/commit/2ee72487665582c499c442b3d58e6bc8654171c3) Update parameters in source files too - [`8a9e3c6`](https://github.com/jmcnamara/libxlsxwriter/commit/8a9e3c671494c475b993d653be9582081dbaf7ce) Merge pull request #1 from jjochen/fix/evanmiller/strict-prototypes ### 📊 Changes **22 files changed** (+22 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `include/xlsxwriter/app.h` (+1 -1) 📝 `include/xlsxwriter/chartsheet.h` (+1 -1) 📝 `include/xlsxwriter/content_types.h` (+1 -1) 📝 `include/xlsxwriter/core.h` (+1 -1) 📝 `include/xlsxwriter/custom.h` (+1 -1) 📝 `include/xlsxwriter/drawing.h` (+1 -1) 📝 `include/xlsxwriter/format.h` (+1 -1) 📝 `include/xlsxwriter/relationships.h` (+1 -1) 📝 `include/xlsxwriter/shared_strings.h` (+1 -1) 📝 `include/xlsxwriter/styles.h` (+1 -1) 📝 `include/xlsxwriter/theme.h` (+1 -1) 📝 `src/app.c` (+1 -1) 📝 `src/content_types.c` (+1 -1) 📝 `src/core.c` (+1 -1) 📝 `src/custom.c` (+1 -1) 📝 `src/drawing.c` (+1 -1) 📝 `src/format.c` (+1 -1) 📝 `src/relationships.c` (+1 -1) 📝 `src/shared_strings.c` (+1 -1) 📝 `src/styles.c` (+1 -1) _...and 2 more files_ </details> ### 📄 Description The C standard (and `-Wstrict-prototypes`) requires that functions which take no arguments be declared as foobar(void) instead of foobar(). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>