[PR #5400] [MERGED] Revert "mpv: whitelist mpv-mpris (#5386)" #5481

New issue

Closed

opened 2026-05-05 10:39:12 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:39:12 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5400
Author: @kmk3
Created: 10/4/2022
Status: ✅ Merged
Merged: 10/4/2022
Merged by: @netblue30

Base: master ← Head: mpv-fix-lib

📝 Commits (1)

3142a1d Revert "mpv: whitelist mpv-mpris (#5386)"

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 etc/profile-m-z/mpv.profile (+0 -1)

📄 Description

This reverts commit 393c5beff2.

Which broke mpv:

$ mpv --version
Cannot start application: No such file or directory

Probably because mpv itself uses many libraries and it has plugins that
may depend on files in /usr/lib as well:

$ pacman -Qlq mpv | grep /lib/ | grep -v '/$'
/usr/lib/libmpv.so
/usr/lib/libmpv.so.1
/usr/lib/libmpv.so.1.109.0
/usr/lib/pkgconfig/mpv.pc
$ strings /usr/bin/mpv | grep '^lib.*\.so' | sort -u | wc -l
53
$ pacman -Qlq yt-dlp | grep /lib/ | grep -v '/$' |
  cut -f -4 -d / | sort -u
/usr/lib/python3.10
$ pacman -Q mpv yt-dlp
mpv 1:0.34.1-5
yt-dlp 2022.09.01-1

Environment: Artix Linux.

Also, private-lib is disabled by default in firejail.config (see #5190)
and mpv.profile does not use private-lib, so there should be no need to
whitelist anything in /usr/lib in the default profile.

Cc: @glitsj16 @rusty-snake @WhyNotHugo (from #5386)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5400 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 10/4/2022 **Status:** ✅ Merged **Merged:** 10/4/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `mpv-fix-lib` --- ### 📝 Commits (1) - [`3142a1d`](https://github.com/netblue30/firejail/commit/3142a1d7720cf3f5abc71fe8393f809f57b10fd1) Revert "mpv: whitelist mpv-mpris (#5386)" ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-m-z/mpv.profile` (+0 -1) </details> ### 📄 Description This reverts commit 393c5beff2686d7732221dadb6730917f24835a0. Which broke mpv: $ mpv --version Cannot start application: No such file or directory Probably because mpv itself uses many libraries and it has plugins that may depend on files in /usr/lib as well: $ pacman -Qlq mpv | grep /lib/ | grep -v '/$' /usr/lib/libmpv.so /usr/lib/libmpv.so.1 /usr/lib/libmpv.so.1.109.0 /usr/lib/pkgconfig/mpv.pc $ strings /usr/bin/mpv | grep '^lib.*\.so' | sort -u | wc -l 53 $ pacman -Qlq yt-dlp | grep /lib/ | grep -v '/$' | cut -f -4 -d / | sort -u /usr/lib/python3.10 $ pacman -Q mpv yt-dlp mpv 1:0.34.1-5 yt-dlp 2022.09.01-1 Environment: Artix Linux. Also, private-lib is disabled by default in firejail.config (see #5190) and mpv.profile does not use private-lib, so there should be no need to whitelist anything in /usr/lib in the default profile. Cc: @glitsj16 @rusty-snake @WhyNotHugo (from #5386) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>