[PR #4574] [MERGED] Fix shellcheck warnings #5190

New issue

Closed

opened 2026-05-05 10:33:54 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:33:54 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4574
Author: @a1346054
Created: 9/22/2021
Status: ✅ Merged
Merged: 11/5/2021
Merged by: @kmk3

Base: master ← Head: shellcheck-fix

📝 Commits (1)

efcd54c Fix some shellcheck warnings

📊 Changes

6 files changed (+37 additions, -37 deletions)

View changed files

📝 gcov.sh (+3 -3)
📝 linecnt.sh (+2 -2)
📝 mkasc.sh (+6 -6)
📝 mkdeb.sh.in (+19 -19)
📝 mkman.sh (+5 -5)
📝 mkuid.sh (+2 -2)

📄 Description

Split from #4497 for further discussion.

I did not modify the configure script, which is a source of a lot of the remaining shellcheck warnings, because it comes from autoconf and so it makes little sense to try to fix it here.

I also did not modify the scripts in contrib, because they possibly are maintained at some other place. Similarly with the other scripts that don't appear to be called from any of the makefiles.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4574 **Author:** [@a1346054](https://github.com/a1346054) **Created:** 9/22/2021 **Status:** ✅ Merged **Merged:** 11/5/2021 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `shellcheck-fix` --- ### 📝 Commits (1) - [`efcd54c`](https://github.com/netblue30/firejail/commit/efcd54c0db501e9438cfc97f3ff2e6aa546ecb55) Fix some shellcheck warnings ### 📊 Changes **6 files changed** (+37 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `gcov.sh` (+3 -3) 📝 `linecnt.sh` (+2 -2) 📝 `mkasc.sh` (+6 -6) 📝 `mkdeb.sh.in` (+19 -19) 📝 `mkman.sh` (+5 -5) 📝 `mkuid.sh` (+2 -2) </details> ### 📄 Description Split from #4497 for further discussion. I did not modify the configure script, which is a source of a lot of the remaining shellcheck warnings, because it comes from autoconf and so it makes little sense to try to fix it here. I also did not modify the scripts in contrib, because they possibly are maintained at some other place. Similarly with the other scripts that don't appear to be called from any of the makefiles. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>