[PR #5202] profiles: nodejs-common: fix node-gyp failing to build canvas #5400

New issue

Open

opened 2026-05-05 10:37:43 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:37:43 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5202
Author: @skrat
Created: 6/14/2022
Status: 🔄 Open

Base: master ← Head: patch-1

📝 Commits (1)

2ae4064 Fix node-gyp failing to build canvas

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 etc/profile-m-z/nodejs-common.profile (+1 -0)

📄 Description

So there is a commonly use node (npm) package called "canvas", which uses node-gyp to bind to cairo (2D canvas drawing library). And I assume this is useful outside of this particular case. node-gyp (run by yarn install or npm install) needs access to /usr/share/pkgconfig otherwise it fails to buold the native extensions.

So it's either this proposed change, or it can be move to yarn.profile or npm.profile. I'm not sure it will work when moved to node-gyp.profile as that one is invoked as a subprocess.

It can also, instead of including build-systems-common.profile just whitelist /usr/share/pkgconfig.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5202 **Author:** [@skrat](https://github.com/skrat) **Created:** 6/14/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`2ae4064`](https://github.com/netblue30/firejail/commit/2ae40641a5e4de2ae386029dbffb3d48b80887b5) Fix node-gyp failing to build canvas ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-m-z/nodejs-common.profile` (+1 -0) </details> ### 📄 Description So there is a commonly use node (npm) package called "canvas", which uses node-gyp to bind to cairo (2D canvas drawing library). And I assume this is useful outside of this particular case. node-gyp (run by `yarn install` or `npm install`) needs access to `/usr/share/pkgconfig` otherwise it fails to buold the native extensions. So it's either this proposed change, or it can be move to `yarn.profile` or `npm.profile`. I'm not sure it will work when moved to `node-gyp.profile` as that one is invoked as a subprocess. It can also, instead of including `build-systems-common.profile` just whitelist `/usr/share/pkgconfig`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>