mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[PR #832] [MERGED] Add key mappings for Kana, Eisu_toggle and Muhenkan #1705
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#1705
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/debauchee/barrier/pull/832
Author: @tom-tan
Created: 8/12/2020
Status: ✅ Merged
Merged: 8/22/2020
Merged by: @p12tic
Base:
master← Head:add-os-barrier-keymap-for-jis-kbd📝 Commits (2)
0fdcf8bAdd key mappings forKana,EisuandMuhenkan4aefd64Add missing comma📊 Changes
2 files changed (+6 additions, -2 deletions)
View changed files
📝
src/lib/platform/MSWindowsKeyState.cpp(+1 -1)📝
src/lib/platform/OSXKeyState.cpp(+5 -1)📄 Description
This request is a continuation of #818 to share Japanese keyboards with Windows and mac computers while keeping Japanese input functionalities.
Windows and mac provide similar but different keys to enable and disable Japanese input methods:
Muhenkan(Windows) <->Eisu_toggle(mac)Henkan(Windows) <->Kana(mac)Making a mapping of these keys is important to share the Japanese keyboards but unfortunately some of these keys are not recognized by barrier.
The request #818 added key entries for
Eisu_toggleandMuhenkanto the barrier internal key representation.This request adds a mapping between the internal representation with OS-specific key representation.
I confirmed that this request makes barrier aware of
Kana,Eisu_toggle,HenkanandMuhenkankeys in thesection: optionssection in the setting file.After merging this request, we can smoothly share Japanese keyboards between Windows and mac computers by adding the following settings (in the case of Windows server):
Note that GUI hotkey editor does not recognize these Japanese IME keys and therefore we have to edit the configuration file directly. Fixing it is out of scope of this request.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.