[PR #832] [MERGED] Add key mappings for Kana, Eisu_toggle and Muhenkan #1705

Closed
opened 2026-05-05 07:59:56 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/832
Author: @tom-tan
Created: 8/12/2020
Status: Merged
Merged: 8/22/2020
Merged by: @p12tic

Base: masterHead: add-os-barrier-keymap-for-jis-kbd


📝 Commits (2)

  • 0fdcf8b Add key mappings for Kana, Eisu and Muhenkan
  • 4aefd64 Add missing comma

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 src/lib/platform/MSWindowsKeyState.cpp (+1 -1)
📝 src/lib/platform/OSXKeyState.cpp (+5 -1)

📄 Description

This request is a continuation of #818 to share Japanese keyboards with Windows and mac computers while keeping Japanese input functionalities.

Windows and mac provide similar but different keys to enable and disable Japanese input methods:

  • Disable Japanese input method: Muhenkan (Windows) <-> Eisu_toggle (mac)
  • Enable Japanese input method: Henkan (Windows) <-> Kana (mac)

Making a mapping of these keys is important to share the Japanese keyboards but unfortunately some of these keys are not recognized by barrier.

The request #818 added key entries for Eisu_toggle and Muhenkan to the barrier internal key representation.
This request adds a mapping between the internal representation with OS-specific key representation.

I confirmed that this request makes barrier aware of Kana, Eisu_toggle, Henkan and Muhenkan keys in the section: options section in the setting file.

After merging this request, we can smoothly share Japanese keyboards between Windows and mac computers by adding the following settings (in the case of Windows server):

section: options
        ...
	keystroke(Henkan) = ;keystroke(Kana,client)
	keystroke(Muhenkan) = ;keystroke(EisuToggle,client)
end

Note that GUI hotkey editor does not recognize these Japanese IME keys and therefore we have to edit the configuration file directly. Fixing it is out of scope of this request.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/832 **Author:** [@tom-tan](https://github.com/tom-tan) **Created:** 8/12/2020 **Status:** ✅ Merged **Merged:** 8/22/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `add-os-barrier-keymap-for-jis-kbd` --- ### 📝 Commits (2) - [`0fdcf8b`](https://github.com/debauchee/barrier/commit/0fdcf8b225be85603fcea86aebd6cd7638f3fa3d) Add key mappings for `Kana`, `Eisu` and `Muhenkan` - [`4aefd64`](https://github.com/debauchee/barrier/commit/4aefd64adda90943cc16ba7d3c3545ecc00ec45f) Add missing comma ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/platform/MSWindowsKeyState.cpp` (+1 -1) 📝 `src/lib/platform/OSXKeyState.cpp` (+5 -1) </details> ### 📄 Description This request is a continuation of #818 to share Japanese keyboards with Windows and mac computers while keeping Japanese input functionalities. Windows and mac provide similar but different keys to enable and disable Japanese input methods: - Disable Japanese input method: `Muhenkan` (Windows) <-> `Eisu_toggle` (mac) - Enable Japanese input method: `Henkan` (Windows) <-> `Kana` (mac) Making a mapping of these keys is important to share the Japanese keyboards but unfortunately some of these keys are not recognized by barrier. The request #818 added key entries for `Eisu_toggle` and `Muhenkan` to the barrier internal key representation. This request adds a mapping between the internal representation with OS-specific key representation. I confirmed that this request makes barrier aware of `Kana`, `Eisu_toggle`, `Henkan` and `Muhenkan` keys in the `section: options` section in the setting file. After merging this request, we can smoothly share Japanese keyboards between Windows and mac computers by adding the following settings (in the case of Windows server): ``` section: options ... keystroke(Henkan) = ;keystroke(Kana,client) keystroke(Muhenkan) = ;keystroke(EisuToggle,client) end ``` Note that GUI hotkey editor does not recognize these Japanese IME keys and therefore we have to edit the configuration file directly. Fixing it is out of scope of this request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:59:56 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/barrier#1705
No description provided.