mirror of
https://github.com/airwindows/airwindows.git
synced 2026-05-15 14:16:00 -06:00
[GH-ISSUE #21] Uninitialized memory on lastSample[L|R] in Loud #16
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/airwindows#16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @baconpaul on GitHub (Nov 9, 2020).
Original GitHub issue: https://github.com/airwindows/airwindows/issues/21
Hi Chris!
Wrapping up the Airwindows surge integration and one of our users noticed that sometimes Loud would come up and clip right away. I investigated.
8aa7017bfd/plugins/MacVST/Loud/source/Loud.cpp (L20)Turns out Loud doesn't initialize
lastSampleLorlastSampleRin its constructor, so if you create a Loud you can get - well - anything. In our situation where we are creating AWFX inside surge, we can often sit on memory that has values and that blows us up.I fixed it by adding a '=0' in the class but I guess you want to add an init in the .cpp there and in the other forks perhaps?
Here's the surge issue which links to the fix we put in our copy of the FX.
https://github.com/surge-synthesizer/surge/issues/2620
Thanks so much! Hope this helps
@airwindows commented on GitHub (Nov 9, 2020):
Thank you! That got past me. I can't fix it tonight but I've just fixed a bug in ClipOnly (where it used a float even for use with double precision VST) and you've found the sort of thing where I will absolutely zip off and fix it and update it in place. I can probably get it tomorrow :)
@baconpaul commented on GitHub (Nov 9, 2020):
Cool! I already have it fixed in our integration in surge so no rush from here, but glad it helps!
We plan to do our prod release in January by the way and air windows integration is one of our three or four big new features. Thanks for making such uniform useful software!
@airwindows commented on GitHub (Nov 9, 2020):
Fixed, and pushed to GitHub. Thank you! If you run across anything else like that, let me know: I can often turn around this type of fix pretty quickly :)