github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[GH-ISSUE #172] Painter/Xform2D: Return statement is never reached. #74

New issue
Closed
opened 2026-05-05 03:38:01 -06:00 by gitea-mirror · 2 comments
gitea-mirror commented 2026-05-05 03:38:01 -06:00
Owner
Copy link

Originally created by @ismail-yilmaz on GitHub (Nov 25, 2023).
Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/172

fb22b9b361/uppsrc/Painter/Xform2D.cpp (L34)

The above return statement in Xform2D::GetClass method is never reached.

Originally created by @ismail-yilmaz on GitHub (Nov 25, 2023). Original GitHub issue: https://github.com/ultimatepp/ultimatepp/issues/172 https://github.com/ultimatepp/ultimatepp/blob/fb22b9b361df668b3290e815a0b91d5a2691d7f0/uppsrc/Painter/Xform2D.cpp#L34 The above return statement in Xform2D::GetClass method is never reached.
gitea-mirror commented 2026-05-05 03:38:04 -06:00
Author
Owner
Copy link

@mirek-fidler commented on GitHub (Nov 27, 2023):

True. That said, GetClass does not seem to be used anywhere anyway, I vote
for completely removing it...

On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz @.***>
wrote:

fb22b9b361/uppsrc/Painter/Xform2D.cpp (L34)

The above return statement in Xform2D::GetClass method is never reached.

—
Reply to this email directly, view it on GitHub
https://github.com/ultimatepp/ultimatepp/issues/172, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

<!-- gh-comment-id:1827848639 --> @mirek-fidler commented on GitHub (Nov 27, 2023): True. That said, GetClass does not seem to be used anywhere anyway, I vote for completely removing it... On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz ***@***.***> wrote: > > https://github.com/ultimatepp/ultimatepp/blob/fb22b9b361df668b3290e815a0b91d5a2691d7f0/uppsrc/Painter/Xform2D.cpp#L34 > > The above return statement in Xform2D::GetClass method is never reached. > > — > Reply to this email directly, view it on GitHub > <https://github.com/ultimatepp/ultimatepp/issues/172>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >
gitea-mirror commented 2026-05-05 03:38:06 -06:00
Author
Owner
Copy link

@ismail-yilmaz commented on GitHub (Nov 27, 2023):

True. That said, GetClass does not seem to be used anywhere anyway, I vote for completely removing it...
…
On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz @.> wrote: fb22b9b361/uppsrc/Painter/Xform2D.cpp (L34) The above return statement in Xform2D::GetClass method is never reached. — Reply to this email directly, view it on GitHub <#172>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

I'm also fine with removing it. While I use Xform2D matrix a lot, I never needed the GetClass method either.

<!-- gh-comment-id:1828331010 --> @ismail-yilmaz commented on GitHub (Nov 27, 2023): > True. That said, GetClass does not seem to be used anywhere anyway, I vote for completely removing it... > […](#) > On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz ***@***.***> wrote: https://github.com/ultimatepp/ultimatepp/blob/fb22b9b361df668b3290e815a0b91d5a2691d7f0/uppsrc/Painter/Xform2D.cpp#L34 The above return statement in Xform2D::GetClass method is never reached. — Reply to this email directly, view it on GitHub <#172>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> I'm also fine with removing it. While I use Xform2D matrix a lot, I never needed the GetClass method either.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#74
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?