github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #124] [CLOSED] remove bitwise or with booleans warnings by changing to plus #172

New issue
Closed
opened 2026-05-05 03:42:09 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:42:09 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/124
Author: @ped7g
Created: 12/25/2022
Status: ❌ Closed

Base: master ← Head: remove_bitwise_or_warning

📝 Commits (2)

  • 2cc5a7d remove bitwise or with booleans warnings by changing to plus
  • 8b42da8 remove bitwise or with booleans warnings by changing to plus - adjust by review comment

📊 Changes

2 files changed (+4 additions, -5 deletions)

View changed files

📝 uppsrc/CtrlCore/GtkEvent.cpp (+1 -1)
📝 uppsrc/CtrlLib/ScrollBar.cpp (+3 -4)

📄 Description

bool(bool(a) | bool(b)) == bool(bool(a) + bool(b)), but without warning suggesting casting to integer.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/124 **Author:** [@ped7g](https://github.com/ped7g) **Created:** 12/25/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remove_bitwise_or_warning` --- ### 📝 Commits (2) - [`2cc5a7d`](https://github.com/ultimatepp/ultimatepp/commit/2cc5a7d50ddcf7aee132400865497e0130c8a005) remove bitwise or with booleans warnings by changing to plus - [`8b42da8`](https://github.com/ultimatepp/ultimatepp/commit/8b42da83793db4062b01da069a26f87b251a3385) remove bitwise or with booleans warnings by changing to plus - adjust by review comment ### 📊 Changes **2 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/GtkEvent.cpp` (+1 -1) 📝 `uppsrc/CtrlLib/ScrollBar.cpp` (+3 -4) </details> ### 📄 Description bool(bool(a) | bool(b)) == bool(bool(a) + bool(b)), but without warning suggesting casting to integer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:42:09 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#172
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?