[PR #347] [MERGED] CtrlCore: Modernize CocoClip to use modern NSPasteboardTypeFileURL and NSPasteboardTypeURL #330

New issue

Closed

opened 2026-05-05 03:45:59 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:45:59 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/347
Author: @klugier
Created: 1/17/2026
Status: ✅ Merged
Merged: 1/17/2026
Merged by: @mirek-fidler

Base: master ← Head: klugier/remove-warnings-coco-clip

📝 Commits (1)

ad8940e Modernize CocoClip to use modern NSPasteboardTypeFileURLand NSPasteboardTypeURL.

📊 Changes

1 file changed (+25 additions, -15 deletions)

View changed files

📝 uppsrc/CtrlCore/CocoClip.mm (+25 -15)

📄 Description

NSFilenamesPboardType and NSURLPboardType are depricated types from macOS 10.14 and needs to be replaced with there newer equivalents. This PR address this issue by replacing them with NSPasteboardTypeFileURL and NSPasteboardTypeURL. In the end eliminating the warning raised by compiler.

I just noticed that in plain version droping url for example from browser doesn't workg and empty vector is being return. This PR changes this and URL is returned normally. It is returrned in the full form for example:

https://examples.com?par1=test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/347 **Author:** [@klugier](https://github.com/klugier) **Created:** 1/17/2026 **Status:** ✅ Merged **Merged:** 1/17/2026 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/remove-warnings-coco-clip` --- ### 📝 Commits (1) - [`ad8940e`](https://github.com/ultimatepp/ultimatepp/commit/ad8940e09c4886f2eb22f821898f256cff911a54) Modernize CocoClip to use modern NSPasteboardTypeFileURLand NSPasteboardTypeURL. ### 📊 Changes **1 file changed** (+25 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/CocoClip.mm` (+25 -15) </details> ### 📄 Description NSFilenamesPboardType and NSURLPboardType are depricated types from macOS 10.14 and needs to be replaced with there newer equivalents. This PR address this issue by replacing them with NSPasteboardTypeFileURL and NSPasteboardTypeURL. In the end eliminating the warning raised by compiler. I just noticed that in plain version droping url for example from browser doesn't workg and empty vector is being return. This PR changes this and URL is returned normally. It is returrned in the full form for example: ``` https://examples.com?par1=test ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:45:59 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#330

No description provided.

Rows
Columns