[PR #364] [MERGED] CtrlCore: fix release caption for tab bar on macOS. #347

New issue

Closed

opened 2026-05-05 03:46:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:46:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/364
Author: @klugier
Created: 1/26/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @mirek-fidler

Base: master ← Head: klugier/fix-release-caption-tab-bar

📝 Commits (2)

bc7415f CtrlCore: fix release caption for tab bar on macOS.
e0b0bae .cosmetics

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlCore/CocoClip.mm (+1 -1)

📄 Description

Seems ReleaseCapture() in Ctrl::DoDragAndDrop for Cocoa is needed to avoid problems with TabBar on macOS. I didn't notice any regressions in other places. Maybe not the cleanest solution, but for now should be fine.

Please keep in mind that the logic in Ctrl::DoDragAndDrop is being continue when user stop drag after executing following code:

[nswindow dragImage:nsimg
	                 at:p
	             offset:NSMakeSize(0, 0)
	              event:sCurrentMouseEvent__
	         pasteboard:Pasteboard(true)
	             source:src
	          slideBack:YES];

Please keep in mind that we will need to rewrite this code to the newer beginDraggingSessionWithItems. dragImage was depricated in latest macOS 26.2. Still compiler doesn't generate warnings, but it will change of the future. So, treat the current code as temporary solution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/364 **Author:** [@klugier](https://github.com/klugier) **Created:** 1/26/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/fix-release-caption-tab-bar` --- ### 📝 Commits (2) - [`bc7415f`](https://github.com/ultimatepp/ultimatepp/commit/bc7415fee23e75da0506d6f9ce5c9fc54be305eb) CtrlCore: fix release caption for tab bar on macOS. - [`e0b0bae`](https://github.com/ultimatepp/ultimatepp/commit/e0b0bae19d1bf0e96d8577c69c3b5ed031a72f7e) .cosmetics ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlCore/CocoClip.mm` (+1 -1) </details> ### 📄 Description Seems ReleaseCapture() in Ctrl::DoDragAndDrop for Cocoa is needed to avoid problems with TabBar on macOS. I didn't notice any regressions in other places. Maybe not the cleanest solution, but for now should be fine. Please keep in mind that the logic in Ctrl::DoDragAndDrop is being continue when user stop drag after executing following code: ``` [nswindow dragImage:nsimg at:p offset:NSMakeSize(0, 0) event:sCurrentMouseEvent__ pasteboard:Pasteboard(true) source:src slideBack:YES]; ``` Please keep in mind that we will need to rewrite this code to the newer beginDraggingSessionWithItems. dragImage was depricated in latest macOS 26.2. Still compiler doesn't generate warnings, but it will change of the future. So, treat the current code as temporary solution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:46:22 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#347

No description provided.

Rows
Columns