duration_ms) #283

New issue

Closed

opened 2026-05-05 03:44:46 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:44:46 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/283
Author: @klugier
Created: 6/15/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @mirek-fidler

Base: master ← Head: klugier/animations-improvemenets

📝 Commits (1)

e9572a1 Added reset button to reference/AnimateCtrlGeometry.

📊 Changes

3 files changed (+40 additions, -16 deletions)

View changed files

📝 reference/AnimateCtrlGeometry/main.cpp (+28 -4)
📝 uppsrc/CtrlCore/src.tpp/Animation_en-us.tpp (+6 -6)
📝 uppsrc/CtrlLib/CtrlUtil.cpp (+6 -6)

📄 Description

The changes introduced in this PR improves CtrlLib animations by:

Adding reset button to reference/AnimateCtrlGeometry, it was annoying to relaunch the reference app to see the animation again
Change the animate function parameter name duration to duration_ms. Thanks to that the signature should be easier to understand, also it is aligned with SetTimeCallback declaration.
Docs has been updated accordingly to changes in Animate function parameter names

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/283 **Author:** [@klugier](https://github.com/klugier) **Created:** 6/15/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `klugier/animations-improvemenets` --- ### 📝 Commits (1) - [`e9572a1`](https://github.com/ultimatepp/ultimatepp/commit/e9572a1e981240dad452cad90ad34ce2f2763bbc) Added reset button to reference/AnimateCtrlGeometry. ### 📊 Changes **3 files changed** (+40 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `reference/AnimateCtrlGeometry/main.cpp` (+28 -4) 📝 `uppsrc/CtrlCore/src.tpp/Animation_en-us.tpp` (+6 -6) 📝 `uppsrc/CtrlLib/CtrlUtil.cpp` (+6 -6) </details> ### 📄 Description The changes introduced in this PR improves CtrlLib animations by: - Adding reset button to reference/AnimateCtrlGeometry, it was annoying to relaunch the reference app to see the animation again - Change the animate function parameter name duration to duration_ms. Thanks to that the signature should be easier to understand, also it is aligned with SetTimeCallback declaration. - Docs has been updated accordingly to changes in Animate function parameter names --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:44:46 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#283

No description provided.

Rows
Columns