github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 14:16:07 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #166] [MERGED] Convert value before showing in popup if it doesn't fit in multibutton #198

New issue
Closed
opened 2026-05-05 03:42:46 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:42:46 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/166
Author: @schutm
Created: 10/17/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @mirek-fidler

Base: master ← Head: schutm-patch-2

📝 Commits (2)

  • 7037744 Convert value before showing in popup if it doesn't fit in multibutton
  • ece6a9f Merge branch 'ultimatepp:master' into schutm-patch-2

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlLib/MultiButton.cpp (+1 -1)

📄 Description

The SyncInfo() of a MultiButton uses the unconverted value to show in the display. This change makes sure the value is converted first (as probably was the intention as a convert->Format() was included, but the converted value was never used).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/166 **Author:** [@schutm](https://github.com/schutm) **Created:** 10/17/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `schutm-patch-2` --- ### 📝 Commits (2) - [`7037744`](https://github.com/ultimatepp/ultimatepp/commit/7037744513a259367408746a39f3ced670707d3a) Convert value before showing in popup if it doesn't fit in multibutton - [`ece6a9f`](https://github.com/ultimatepp/ultimatepp/commit/ece6a9fde33b6ae50be8849994eb4b9da340a914) Merge branch 'ultimatepp:master' into schutm-patch-2 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/MultiButton.cpp` (+1 -1) </details> ### 📄 Description The SyncInfo() of a MultiButton uses the unconverted value to show in the display. This change makes sure the value is converted first (as probably was the intention as a convert->Format() was included, but the converted value was never used). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:42:46 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#198
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?