[PR #118] [CLOSED] one possible bugfix, and few more small changes to lower amount of warnings while building ide #166

New issue

Closed

opened 2026-05-05 03:42:02 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:42:02 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/118
Author: @ped7g
Created: 12/11/2022
Status: ❌ Closed

Base: master ← Head: small_changes

📝 Commits (6)

b758910 ide: possible OOB access into sOperatorTab with signed-char index -128..-1
7dabfcf CtrlLib: warning-fix friend class Popup used for struct Popup
33cda46 Core: fix unused variable s by using it
9a0a4aa ide: remove unused function sSplitT
83c45df ide: remove most of the unused variables reported during build of ide
ce79b8d CtrlLib: remove one logical-operator priority warning

📊 Changes

12 files changed (+7 additions, -21 deletions)

View changed files

📝 uppsrc/Core/Mt.cpp (+2 -2)
📝 uppsrc/Core/Stream.cpp (+1 -1)
📝 uppsrc/CtrlCore/CtrlDraw.cpp (+0 -1)
📝 uppsrc/CtrlCore/GtkEvent.cpp (+0 -1)
📝 uppsrc/CtrlLib/DropChoice.h (+1 -1)
📝 uppsrc/CtrlLib/PopUpList.cpp (+1 -1)
📝 uppsrc/CtrlLib/ScrollBar.cpp (+0 -1)
📝 uppsrc/RichText/TxtPaint.cpp (+0 -2)
📝 uppsrc/ide/About.cpp (+0 -1)
📝 uppsrc/ide/Browser/CodeRef.cpp (+0 -4)
📝 uppsrc/ide/clang/Indexer.cpp (+0 -1)
📝 uppsrc/ide/clang/Signature.cpp (+2 -5)

📄 Description

build platform: KDE neon (based on Ubuntu 22.04), clang 14.0.0 in C++20 mode
(except changing build method to -std=c++20, it's the default CLANG build method after cloning git repository and using make to build IDE from command line)

There are still some warnings left, but some of those can't be resolved as cleanly, the | vs || would require extra casting to int, and some unused variables are used for diagnostic or debug builds. Also I avoided Assist.cpp and Navigator.cpp just in case Mirek is still editing them a lot.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/118 **Author:** [@ped7g](https://github.com/ped7g) **Created:** 12/11/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `small_changes` --- ### 📝 Commits (6) - [`b758910`](https://github.com/ultimatepp/ultimatepp/commit/b7589105c9595377b804a9b0ec597856066c3376) ide: possible OOB access into sOperatorTab with signed-char index -128..-1 - [`7dabfcf`](https://github.com/ultimatepp/ultimatepp/commit/7dabfcf6ef83b81d69a98721721431baefd2a71b) CtrlLib: warning-fix `friend class Popup` used for `struct Popup` - [`33cda46`](https://github.com/ultimatepp/ultimatepp/commit/33cda46ebb97bea596a59a99dc966d314c027473) Core: fix unused variable `s` by using it - [`9a0a4aa`](https://github.com/ultimatepp/ultimatepp/commit/9a0a4aae31c352c6f20b34dd91f25aec95f3727c) ide: remove unused function sSplitT - [`83c45df`](https://github.com/ultimatepp/ultimatepp/commit/83c45df1e3e700b869591e279cb385cf7529e7f5) ide: remove most of the unused variables reported during build of ide - [`ce79b8d`](https://github.com/ultimatepp/ultimatepp/commit/ce79b8d488b79ad3326aeff9ef129caed58e674d) CtrlLib: remove one logical-operator priority warning ### 📊 Changes **12 files changed** (+7 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Core/Mt.cpp` (+2 -2) 📝 `uppsrc/Core/Stream.cpp` (+1 -1) 📝 `uppsrc/CtrlCore/CtrlDraw.cpp` (+0 -1) 📝 `uppsrc/CtrlCore/GtkEvent.cpp` (+0 -1) 📝 `uppsrc/CtrlLib/DropChoice.h` (+1 -1) 📝 `uppsrc/CtrlLib/PopUpList.cpp` (+1 -1) 📝 `uppsrc/CtrlLib/ScrollBar.cpp` (+0 -1) 📝 `uppsrc/RichText/TxtPaint.cpp` (+0 -2) 📝 `uppsrc/ide/About.cpp` (+0 -1) 📝 `uppsrc/ide/Browser/CodeRef.cpp` (+0 -4) 📝 `uppsrc/ide/clang/Indexer.cpp` (+0 -1) 📝 `uppsrc/ide/clang/Signature.cpp` (+2 -5) </details> ### 📄 Description build platform: KDE neon (based on Ubuntu 22.04), clang 14.0.0 in C++20 mode (except changing build method to -std=c++20, it's the default CLANG build method after cloning git repository and using make to build IDE from command line) There are still some warnings left, but some of those can't be resolved as cleanly, the `|` vs `||` would require extra casting to `int`, and some unused variables are used for diagnostic or debug builds. Also I avoided Assist.cpp and Navigator.cpp just in case Mirek is still editing them a lot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>