[PR #113] [CLOSED] Eliminating compilation warning from CtrlLib::PopUpList class #162

New issue

Closed

opened 2026-05-05 03:41:54 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:41:54 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/113
Author: @klugier
Created: 10/31/2022
Status: ❌ Closed

Base: master ← Head: klugier/compilation-warning-ctrllib-pop-up-list

📝 Commits (1)

e086487 Eliminating compilation warning in CtrlLib::PopUpList

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/CtrlLib/DropChoice.h (+1 -1)

📄 Description

friend declaration should do not mix class with struct. So, if the parent structure is declare as struct in friend operation we should use exactly the same keyword. In the context of our code PopUpList has this problem.

Tested with ARM Clang on macOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/113 **Author:** [@klugier](https://github.com/klugier) **Created:** 10/31/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `klugier/compilation-warning-ctrllib-pop-up-list` --- ### 📝 Commits (1) - [`e086487`](https://github.com/ultimatepp/ultimatepp/commit/e0864878d62e7830efbfe17765b3c06fd93a0fee) Eliminating compilation warning in CtrlLib::PopUpList ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/CtrlLib/DropChoice.h` (+1 -1) </details> ### 📄 Description friend declaration should do not mix class with struct. So, if the parent structure is declare as struct in friend operation we should use exactly the same keyword. In the context of our code PopUpList has this problem. Tested with ARM Clang on macOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 03:41:54 -06:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#162

No description provided.

Rows
Columns