[PR #12] [CLOSED] VecLine::Clip infinite recursion fix #113

New issue

Closed

opened 2026-05-05 03:40:36 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:40:36 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/12
Author: @erikjwaxx
Created: 3/3/2020
Status: ❌ Closed

Base: master ← Head: VecLine-Clip-infinite-recursion-fix

📝 Commits (1)

0a9fe12 Fix VecLine::Clip infinite recursion in Geom/geometry.h

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 uppsrc/Geom/geometry.h (+1 -1)

📄 Description

It looks like, from looking at the function signature Clip(const Rectf& rect) const that the intent here is to keep the operated-on VecLine immutable and return a copy clipped by rect.

This change effects that logic while breaking the infinite recursion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/12 **Author:** [@erikjwaxx](https://github.com/erikjwaxx) **Created:** 3/3/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `VecLine-Clip-infinite-recursion-fix` --- ### 📝 Commits (1) - [`0a9fe12`](https://github.com/ultimatepp/ultimatepp/commit/0a9fe12faaf82605b8d00ddf89e1a794471facb7) Fix VecLine::Clip infinite recursion in Geom/geometry.h ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Geom/geometry.h` (+1 -1) </details> ### 📄 Description It looks like, from looking at the function signature `Clip(const Rectf& rect) const` that the intent here is to keep the operated-on `VecLine` immutable and return a _copy_ clipped by `rect`. This change effects that logic while breaking the infinite recursion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>