github-starred/ultimatepp
2
0
Fork 0
mirror of https://github.com/ultimatepp/ultimatepp.git synced 2026-05-15 06:05:58 -06:00
Code Issues 33 Projects Packages Wiki Activity Actions

[PR #107] [MERGED] VirtualGui fixes (crash & compilation error) #158

New issue
Closed
opened 2026-05-05 03:41:48 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 03:41:48 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/107
Author: @ismail-yilmaz
Created: 10/10/2022
Status: ✅ Merged
Merged: 10/11/2022
Merged by: @mirek-fidler

Base: master ← Head: ctrl_getowner_fix

📝 Commits (1)

  • 96a3181 VirtualGui: Ctrl::GetOwner() bounds check added. & missing Ctrl::GetCaretBlinkTime() implemented.

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 uppsrc/VirtualGui/Ctrl.h (+2 -0)
📝 uppsrc/VirtualGui/Wnd.cpp (+6 -4)

📄 Description

This patch aims to deal with two urgent issues in VirtualGui:

  • Fixes a crash in Ctrl::GetOwner() by implementing a proper bounds checking.
  • Fixes a compilation error, by adding the missing static GetCaretBlinkTime() function.

Both issue is present right from the start when checked with Turtle/WebWordExample

Please review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/107 **Author:** [@ismail-yilmaz](https://github.com/ismail-yilmaz) **Created:** 10/10/2022 **Status:** ✅ Merged **Merged:** 10/11/2022 **Merged by:** [@mirek-fidler](https://github.com/mirek-fidler) **Base:** `master` ← **Head:** `ctrl_getowner_fix` --- ### 📝 Commits (1) - [`96a3181`](https://github.com/ultimatepp/ultimatepp/commit/96a31816d34f05708a4a758f3f23fbca875ee732) VirtualGui: Ctrl::GetOwner() bounds check added. & missing Ctrl::GetCaretBlinkTime() implemented. ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/VirtualGui/Ctrl.h` (+2 -0) 📝 `uppsrc/VirtualGui/Wnd.cpp` (+6 -4) </details> ### 📄 Description This patch aims to deal with two urgent issues in VirtualGui: - Fixes a crash in Ctrl::GetOwner() by implementing a proper bounds checking. - Fixes a compilation error, by adding the missing static GetCaretBlinkTime() function. Both issue is present right from the start when checked with Turtle/WebWordExample Please review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:41:48 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
virtual_popups
QHD
klugier/view-draw-grid-ctrl-removal
custome_titlebar_refactor
klugier/help-icon-after-line-display
X11S
klugier/umk-check-git-command-statuses
diagram_dev
stable
klugier/lambda-captuer-warnings-gui-01
custom_titlebar
next2025_1
DarkModeContent
release_2024_1
pixelmode
blocksel
skin
bad_alloc
logs
TopSetRect
klugier/gdk-get-workarea-fixed-wayland
doc2024
Core2024
upp_14
animations
_t
layzoom
v2026.1
v2021.1
v2022.1
v2022.2
v2022.3
v2023.1
v2023.2
v2024.1
v2024.1.1
v2025.1
v2025.1.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/ultimatepp#158
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?