[PR #8] [CLOSED] Core: IsDoubleWidth() function to simplify handling of double width Unicode characters #107

New issue

Closed

opened 2026-05-05 03:40:29 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:40:29 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ultimatepp/ultimatepp/pull/8
Author: @ismail-yilmaz
Created: 11/18/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

e1a696b Core: IsDoubleWidth() function is added to simplify handling of double-width UNICODE characters.

📊 Changes

3 files changed (+28 additions, -0 deletions)

View changed files

📝 uppsrc/Core/CharSet.cpp (+21 -0)
📝 uppsrc/Core/CharSet.h (+2 -0)
📝 uppsrc/Core/src.tpp/CharSet_en-us.tpp (+5 -0)

📄 Description

I propose adding IsDoubleWidth() function to Upp/Core.
It simplifies Eastern-Asian/CJK character handling, and seems to cover more than IsCJKIdeograph().
This code is a "rip-off" from Markus Kuhns wcwidth() implementation.. It is widely used, and doesn't seem to have a problematic license.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ultimatepp/ultimatepp/pull/8 **Author:** [@ismail-yilmaz](https://github.com/ismail-yilmaz) **Created:** 11/18/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e1a696b`](https://github.com/ultimatepp/ultimatepp/commit/e1a696b162d9f8c5bebf7d2bf33ca99c53f7d412) Core: IsDoubleWidth() function is added to simplify handling of double-width UNICODE characters. ### 📊 Changes **3 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `uppsrc/Core/CharSet.cpp` (+21 -0) 📝 `uppsrc/Core/CharSet.h` (+2 -0) 📝 `uppsrc/Core/src.tpp/CharSet_en-us.tpp` (+5 -0) </details> ### 📄 Description I propose adding IsDoubleWidth() function to Upp/Core. It simplifies Eastern-Asian/CJK character handling, and seems to cover more than IsCJKIdeograph(). This code is a "rip-off" from [Markus Kuhns wcwidth() implementation.](https://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c). It is widely used, and doesn't seem to have a problematic license. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>