[PR #128] [MERGED] Let NetVariant::fromQJSValue consume all QObject derived types. #219

New issue

Closed

opened 2026-05-05 11:21:04 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:21:04 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/128
Author: @afillebrown
Created: 4/25/2019
Status: ✅ Merged
Merged: 4/25/2019
Merged by: @pauldotknopf

Base: develop ← Head: afillebrown/develop

📝 Commits (1)

ec18a48 Let NetVariant::fromQJSValue consume all QObject derived types.

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/native/QmlNet/QmlNet/qml/NetVariant.cpp (+2 -2)

📄 Description

A QObject wrapped in a QJSValue can not be passed from C++ to QmlNet even though QObject interaction is now supported for QObject types not derived from NetValueInterface. This PR updates the NetVariant::fromQJSValue function to create a valid NetVariant from any QObject, not just QObject types derived from NetValueInterface.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/128 **Author:** [@afillebrown](https://github.com/afillebrown) **Created:** 4/25/2019 **Status:** ✅ Merged **Merged:** 4/25/2019 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `afillebrown/develop` --- ### 📝 Commits (1) - [`ec18a48`](https://github.com/qmlnet/qmlnet/commit/ec18a481e0f1b5f115cf83fd5caa6e13006cdef9) Let NetVariant::fromQJSValue consume all QObject derived types. ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.cpp` (+2 -2) </details> ### 📄 Description A QObject wrapped in a QJSValue can not be passed from C++ to QmlNet even though QObject interaction is now supported for QObject types not derived from NetValueInterface. This PR updates the NetVariant::fromQJSValue function to create a valid NetVariant from any QObject, not just QObject types derived from NetValueInterface. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>