[PR #85] [MERGED] Added long and float type upport + some cleanup/refactoring #198

New issue

Closed

opened 2026-05-05 11:20:40 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:40 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/85
Author: @TripleWhy
Created: 12/19/2018
Status: ✅ Merged
Merged: 12/22/2018
Merged by: @pauldotknopf

Base: develop ← Head: develop

📝 Commits (8)

26dba43 Updated appveyor build script to use MSVC2017
c2c5a00 NetVariant Refactoring
6c951ae Help the compiler help us
f76bdb1 Ran clang-tidy and fixed some reported issues
5bf0bd2 Removed now obsolete arguments
6300130 Use delete[] to avoid undefined behavior
a1f65ff Avoid -Wweak-vtables warning
ed59578 Relaxed assertion that was a little too enthusiastic

📊 Changes

47 files changed (+689 additions, -538 deletions)

View changed files

📝 appveyor.yml (+1 -0)
📝 build/appveyor.bat (+2 -2)
📝 src/native/QmlNet/QmlNet.h (+13 -10)
📝 src/native/QmlNet/QmlNet/qml/JsNetObject.cpp (+21 -23)
📝 src/native/QmlNet/QmlNet/qml/JsNetObject.h (+3 -3)
📝 src/native/QmlNet/QmlNet/qml/NetJsValue.cpp (+8 -7)
📝 src/native/QmlNet/QmlNet/qml/NetJsValue.h (+4 -4)
📝 src/native/QmlNet/QmlNet/qml/NetListModel.cpp (+5 -4)
📝 src/native/QmlNet/QmlNet/qml/NetListModel.h (+1 -1)
📝 src/native/QmlNet/QmlNet/qml/NetTestHelper.cpp (+1 -1)
📝 src/native/QmlNet/QmlNet/qml/NetValue.cpp (+11 -10)
📝 src/native/QmlNet/QmlNet/qml/NetValue.h (+5 -4)
📝 src/native/QmlNet/QmlNet/qml/NetValueMetaObject.cpp (+3 -3)
📝 src/native/QmlNet/QmlNet/qml/NetValueMetaObject.h (+2 -2)
📝 src/native/QmlNet/QmlNet/qml/NetValueMetaObjectPacker.cpp (+79 -78)
📝 src/native/QmlNet/QmlNet/qml/NetValueMetaObjectPacker.h (+2 -2)
📝 src/native/QmlNet/QmlNet/qml/NetVariant.cpp (+217 -184)
📝 src/native/QmlNet/QmlNet/qml/NetVariant.h (+36 -18)
📝 src/native/QmlNet/QmlNet/qml/NetVariantList.cpp (+3 -9)
📝 src/native/QmlNet/QmlNet/qml/NetVariantList.h (+1 -1)

...and 27 more files

📄 Description

Added support for long, unsigned long and float
Some code simplifications
- msvc2015 does not handle some of the qMetaTypeId calls correctly, so I upgraded the appveyor script to use msvc2017 instead
Ran clang-tidy on the c++ code and fixed most reported issues

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/85 **Author:** [@TripleWhy](https://github.com/TripleWhy) **Created:** 12/19/2018 **Status:** ✅ Merged **Merged:** 12/22/2018 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (8) - [`26dba43`](https://github.com/qmlnet/qmlnet/commit/26dba43a696232dd65e7acd9e9b78fcda034d3d5) Updated appveyor build script to use MSVC2017 - [`c2c5a00`](https://github.com/qmlnet/qmlnet/commit/c2c5a00785c192e46228d39cc0b2fab1fa8f0fba) NetVariant Refactoring - [`6c951ae`](https://github.com/qmlnet/qmlnet/commit/6c951ae9f75168f7d2280fb930f80213c75073fc) Help the compiler help us - [`f76bdb1`](https://github.com/qmlnet/qmlnet/commit/f76bdb17a1cfdcfbe8f206d247fc8c1cd90c349e) Ran clang-tidy and fixed some reported issues - [`5bf0bd2`](https://github.com/qmlnet/qmlnet/commit/5bf0bd28fe0d6299c0b122a279434df7efd19d38) Removed now obsolete arguments - [`6300130`](https://github.com/qmlnet/qmlnet/commit/6300130635661accd36e4e2a7156334e33f9a9b5) Use delete[] to avoid undefined behavior - [`a1f65ff`](https://github.com/qmlnet/qmlnet/commit/a1f65ff84c64e35c8fbe8cbb3a3cde6e3f1ab36a) Avoid -Wweak-vtables warning - [`ed59578`](https://github.com/qmlnet/qmlnet/commit/ed5957880d34890274357099614b12da1f9ad16a) Relaxed assertion that was a little too enthusiastic ### 📊 Changes **47 files changed** (+689 additions, -538 deletions) <details> <summary>View changed files</summary> 📝 `appveyor.yml` (+1 -0) 📝 `build/appveyor.bat` (+2 -2) 📝 `src/native/QmlNet/QmlNet.h` (+13 -10) 📝 `src/native/QmlNet/QmlNet/qml/JsNetObject.cpp` (+21 -23) 📝 `src/native/QmlNet/QmlNet/qml/JsNetObject.h` (+3 -3) 📝 `src/native/QmlNet/QmlNet/qml/NetJsValue.cpp` (+8 -7) 📝 `src/native/QmlNet/QmlNet/qml/NetJsValue.h` (+4 -4) 📝 `src/native/QmlNet/QmlNet/qml/NetListModel.cpp` (+5 -4) 📝 `src/native/QmlNet/QmlNet/qml/NetListModel.h` (+1 -1) 📝 `src/native/QmlNet/QmlNet/qml/NetTestHelper.cpp` (+1 -1) 📝 `src/native/QmlNet/QmlNet/qml/NetValue.cpp` (+11 -10) 📝 `src/native/QmlNet/QmlNet/qml/NetValue.h` (+5 -4) 📝 `src/native/QmlNet/QmlNet/qml/NetValueMetaObject.cpp` (+3 -3) 📝 `src/native/QmlNet/QmlNet/qml/NetValueMetaObject.h` (+2 -2) 📝 `src/native/QmlNet/QmlNet/qml/NetValueMetaObjectPacker.cpp` (+79 -78) 📝 `src/native/QmlNet/QmlNet/qml/NetValueMetaObjectPacker.h` (+2 -2) 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.cpp` (+217 -184) 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.h` (+36 -18) 📝 `src/native/QmlNet/QmlNet/qml/NetVariantList.cpp` (+3 -9) 📝 `src/native/QmlNet/QmlNet/qml/NetVariantList.h` (+1 -1) _...and 27 more files_ </details> ### 📄 Description - Added support for long, unsigned long and float - Some code simplifications - msvc2015 does not handle some of the qMetaTypeId calls correctly, so I upgraded the appveyor script to use msvc2017 instead - Ran clang-tidy on the c++ code and fixed most reported issues --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>