mirror of
https://github.com/kusti8/proton-native.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #88] NPM install fails on Windows 10, Node 10 #54
Labels
No labels
bug
documentation
enhancement
libui issue
pull-request
question
wait for libui implementation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/proton-native#54
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @matiit on GitHub (May 2, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/88
@mischnic commented on GitHub (May 2, 2018):
@albe-rosado
Your error logging code:
console.log(ansiColors.red, '${errorMessage}');.I think with
console.log(ansiColors.red, errorMessage);, it wouldnt just say[object Object].Works fine with Node 10 and macOS Sierra.
@jakubtuchol commented on GitHub (May 2, 2018):
I got the same error on macOS High Sierra, Node 10. I installed
create-proton-applocally, and then attempted running./node_modules/.bin/create-proton-app new-app. I got an identical error.@mischnic commented on GitHub (May 2, 2018):
Could you (both) please try installing
proton-nativeitself directly?Is the npm package
windows-build-tools(for Windows) or Xcode (macOS) installed?@matiit commented on GitHub (May 2, 2018):
Reinstalling
proton-nativedidn't help.The
windows-build-toolspackage was not installed on my system, installing it now and will try reinstallingproton-nativethen.@matiit commented on GitHub (May 2, 2018):
Installing
windows-build-toolshave worked indeed.Thank you @mischnic
@albe-rosado commented on GitHub (May 2, 2018):
@jakubtuchol did installing windows-build-tools worked for you?
@albe-rosado commented on GitHub (May 2, 2018):
I updated the readme on create-proton-app stating the required dep for windows.
@mischnic commented on GitHub (May 2, 2018):
Well, on macOS it won't work. 😄
@albe-rosado commented on GitHub (May 2, 2018):
i meant oh, that was the macOS person lol.... that is weird, i do have a mac , let me try
@albe-rosado commented on GitHub (May 2, 2018):
It works! tried with npx and installing globally.
@mischnic commented on GitHub (May 2, 2018):
What version do you have? I use Sierra and had no problem.
Did you see https://github.com/kusti8/proton-native/issues/88#issuecomment-386067413 ?
@jesseruth commented on GitHub (May 2, 2018):
I just tried installing this on mac and got the same error:
at <anonymous> (node:22653) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1) (node:22653) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.@albe-rosado commented on GitHub (May 2, 2018):
mmm, will take a look at that, I can't reproduce the issue tho. @madongo are you on windows? if yes, loot above , if not, can you share your version of node and npm, as well as your OS ?
@albe-rosado commented on GitHub (May 2, 2018):
Also, we should move this to
create-proton-apprepo, this is not proton-native related, can anyone reopen the issue over there, with details? @mischnic can you reproduce it?@mischnic commented on GitHub (May 2, 2018):
@albe-rosado
No problem with macOS Sierra. And in the first comment I made here, I pointed out that your code might hide the real error which got thrown somewhere unexpectedly. Did you see that?
@albe-rosado commented on GitHub (May 2, 2018):
you are right!, let me update that
@jesseruth commented on GitHub (May 2, 2018):
Hey I am on Mac
Node - v9.5.0
High Sierra - 10.13.3 (17D47)
I tried it with node v10 and I am not having any luck either
@albe-rosado commented on GitHub (May 2, 2018):
@mischnic actually, I just looked at the code,
erroMessageis a string, so you won't get [object Object]. Although I would like to print the stdout/stderr to give a better idea to the developer what went wrong, will do that.@albe-rosado commented on GitHub (May 2, 2018):
@madongo @jakubtuchol a new version is up, please update to create-proton-app@1.1.5
@albe-rosado commented on GitHub (May 2, 2018):
you will get better logging, so we will be able to know what happended on your enviroment. :)
@jakubtuchol commented on GitHub (May 3, 2018):
@albe-rosado I didn't have to install
windows-build-tools, but I was able to verify thatcreate-proton-appwas able to work successfully. Thanks so much!@iamwelk commented on GitHub (May 3, 2018):
I have the same error..
@albe-rosado commented on GitHub (May 3, 2018):
@iamwelk do you have create-proton-app@1.1.5? can you share the logs?
@kusti8 commented on GitHub (May 19, 2018):
Closed due to inactivity. If the problem persists, create a new issue.