mirror of
https://github.com/kusti8/proton-native.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #54] Use upstream libui-node #30
Labels
No labels
bug
documentation
enhancement
libui issue
pull-request
question
wait for libui implementation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/proton-native#30
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mischnic on GitHub (Mar 15, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/54
The upstream libui-node master should now equal your fork (
$ORIGINrpath on linux and copyingnbind.nodeto the root folder), but it also sets the rpath correctly for macOS.7741dd2fcc/package.json (L36)@kusti8 commented on GitHub (Mar 15, 2018):
Ok looks good. Did you increment the version a d publish to npm because I didn't see that in your diffs.
@mischnic commented on GitHub (Mar 18, 2018):
@parro-it ?
@parro-it commented on GitHub (Mar 19, 2018):
Just released 0.1.0 on npm.
I'm testing now with my fork of proton... I will publish a PR here.
@mischnic commented on GitHub (Mar 19, 2018):
@parro-it This can get you started:
d42ab2b731@parro-it commented on GitHub (Mar 19, 2018):
Oh great! if you open a PR here of your forks I'll push further changes there (I don't know if I need specific permission to do so)
@kusti8 commented on GitHub (Mar 19, 2018):
Does libui not need to be initialized anymore ? I noticed that was taken out in the fork.
@parro-it commented on GitHub (Mar 19, 2018):
Any idea why I get Electron installed when I
npm installproton?Electron is not a direct proton dependency AFAIK
@parro-it commented on GitHub (Mar 19, 2018):
No, init is now called automatically the first time you require the module. We'll have to update docs & examples
@mischnic commented on GitHub (Mar 19, 2018):
Not of proton, but the react dev tools:
57896ffed9/package.json (L50)@kusti8 How does integration with the dev tools work? This doesn't:
e10f481861/src/render/index.js (L17-L22)PR: https://github.com/kusti8/proton-native/pull/57
@kusti8 commented on GitHub (Mar 19, 2018):
I used to use the dev tools to debug some of the code that wasn't working.
It isn't strictly necessary anymore.
On Mon, Mar 19, 2018, 2:49 PM Niklas Mischkulnig notifications@github.com
wrote:
@mischnic commented on GitHub (Mar 19, 2018):
I tried commenting out these lines and the dev tools started by
npx react-dev-tooldidn't connect to proton.@parro-it commented on GitHub (Mar 19, 2018):
It's working 🎉
@mischnic I pushed to your fork