mirror of
https://github.com/XuehaiPan/nvitop.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #18] [Feature Request] torch_geometric support #18
Labels
No labels
api
bug
bug
cli / tui
dependencies
documentation
documentation
documentation
duplicate
enhancement
exporter
invalid
pull-request
pynvml
question
question
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/nvitop#18
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @plutonium-239 on GitHub (May 27, 2022).
Original GitHub issue: https://github.com/XuehaiPan/nvitop/issues/18
Originally assigned to: @XuehaiPan on GitHub.
First of all, thank you for the excellent
nvitop.I want to know if you have plans to add an integration with
PyTorch Geometric (pyg)? It is a really great library for GNNs. I don't know if its helpful at all but it also has some profiling functions in thetorch_geometric.profilemodule.Since pytorch lightning doesn't give you granular control over your models (sometimes reqd in research) I haven't seen anyone use it. On the flipside, pytorch geometric is probably the most popular library for GNNs.
Hope you consider this!
@XuehaiPan commented on GitHub (May 30, 2022):
Hi @plutonium-239, thanks for the suggestion. I'll be investigating in these two weeks.
nvitop.coreprovides low-level APIs that users can integrate it into their training/testing code.nvitop.callbacksoffers framework high-level APIs.I'm thinking of adding a more customizable mid-level API, e.g., a background daemon gathering the process status (both on host and GPUs). Let the users log the useful items into
tensorboard.SummaryWriter,csv, or print tostdout.@XuehaiPan commented on GitHub (Jun 22, 2022):
Hi @plutonium-239, I have looked into the source code of
PyTorch Geometric (pyg). It looks thatpygsupports PyTorch Lightning and the callback innvitopis also usable.For flexibility, I implement a new metric collector in PR #21, which allows the user has full control of the code logic of DL training.
For example:
The results can be easily logged into TensorBoard or to CSV file.
@XuehaiPan commented on GitHub (Jun 22, 2022):
Since the new feature is built on top of branch
mig-support, which has not been released yet. To install:Any feedback is welcome.
@plutonium-239 commented on GitHub (Jun 24, 2022):
This is awesome!
Thanks so much!
@XuehaiPan commented on GitHub (Jun 26, 2022):
Close as resolved by PR #21.