mirror of
https://github.com/XuehaiPan/nvitop.git
synced 2026-05-15 06:06:12 -06:00
[PR #130] [MERGED] feat(api): handle exceptions for function getpass.getuser() #169
Labels
No labels
api
bug
bug
cli / tui
dependencies
documentation
documentation
documentation
duplicate
enhancement
exporter
invalid
pull-request
pynvml
question
question
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/nvitop#169
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/XuehaiPan/nvitop/pull/130
Author: @XuehaiPan
Created: 7/12/2024
Status: ✅ Merged
Merged: 7/12/2024
Merged by: @XuehaiPan
Base:
main← Head:getuser📝 Commits (3)
ebca048feat(api): handle exceptions for functiongetpass.getuser()a541413chore(pre-commit): update pre-commit hooks511757adocs(CHANGELOG): update CHANGELOG.md📊 Changes
6 files changed (+43 additions, -25 deletions)
View changed files
📝
.pre-commit-config.yaml(+1 -1)📝
CHANGELOG.md(+1 -1)📝
docs/source/spelling_wordlist.txt(+1 -0)📝
nvitop/api/host.py(+21 -1)📝
nvitop/gui/library/utils.py(+13 -16)📝
nvitop/select.py(+6 -6)📄 Description
Issue Type
Description
Move the
getuser()function under acontextlib.suppress(ImportError, OSError)context.Motivation and Context
Resolves #129
cc @landgraf @quarckster
This would also resolve an incoming change of the exception type in the Python upstream in Python 3.13.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.