[PR #34] [MERGED] feat(gui): support process tagging #131

Closed
opened 2026-05-05 03:26:27 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/34
Author: @XuehaiPan
Created: 9/4/2022
Status: Merged
Merged: 9/6/2022
Merged by: @XuehaiPan

Base: mainHead: tagging


📝 Commits (10+)

  • d8a47ac feat(gui): support process tagging in main screen
  • 5d25bea refactor(gui): rename variables
  • 87027f1 feat(gui): support process tagging in tree-view screen
  • d846500 feat(gui): add global attribute
  • 53fe991 chore(gui/help): update help screen
  • 055dc9a chore(gui): dim not owned processes
  • 187d650 chore(gui): update preserved colors
  • c1be779 chore(gui): update selection reseting
  • 387f8d1 docs: update screenshot for help screen
  • f106a29 style: resolve pylint warnings

📊 Changes

18 files changed (+254 additions, -133 deletions)

View changed files

📝 .github/workflows/build.yaml (+7 -1)
📝 README.md (+2 -1)
📝 nvitop/core/device.py (+16 -7)
📝 nvitop/core/libnvml.py (+2 -2)
📝 nvitop/gui/library/history.py (+1 -1)
📝 nvitop/gui/library/libcurses.py (+20 -5)
📝 nvitop/gui/screens/environ.py (+1 -1)
📝 nvitop/gui/screens/help.py (+7 -7)
📝 nvitop/gui/screens/main/__init__.py (+20 -15)
📝 nvitop/gui/screens/main/device.py (+9 -4)
📝 nvitop/gui/screens/main/host.py (+2 -2)
📝 nvitop/gui/screens/main/process.py (+44 -22)
📝 nvitop/gui/screens/main/utils.py (+45 -28)
📝 nvitop/gui/screens/treeview.py (+57 -27)
📝 nvitop/gui/top.py (+8 -6)
📝 nvitop/version.py (+11 -2)
📝 pyproject.toml (+1 -1)
📝 requirements.txt (+1 -1)

📄 Description

Issue Type

  • Improvement/feature implementation

Runtime Environment

  • Operating system and version: Ubuntu 20.04 LTS
  • Terminal emulator and version: GNOME Terminal 3.36.2
  • Python version: 3.9.13
  • NVML version (driver version): 470.129.06
  • nvitop version or commit: v0.7.1
  • python-ml-py version: 11.450.51
  • Locale: en_US.UTF-8

Description

Add process tagging support to the main and tree-view screens. Now the user can select multiple processes and kill them in a single K keystroke.

Motivation and Context

Select multiple processes and kill them in a single K keystroke, rather than kill processes one by one.

Testing

N/A

Images / Videos

Process tagging on the main screen:

main

Process tagging on the tree-view screen:

tree-view

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/34 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 9/4/2022 **Status:** ✅ Merged **Merged:** 9/6/2022 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `tagging` --- ### 📝 Commits (10+) - [`d8a47ac`](https://github.com/XuehaiPan/nvitop/commit/d8a47ac6ca40d229b9e00a3d2caa728f12650383) feat(gui): support process tagging in main screen - [`5d25bea`](https://github.com/XuehaiPan/nvitop/commit/5d25beaa4efd650b985018ffc476990de5e289a8) refactor(gui): rename variables - [`87027f1`](https://github.com/XuehaiPan/nvitop/commit/87027f148c43c7eb2d903c7a7282e875d6126d53) feat(gui): support process tagging in tree-view screen - [`d846500`](https://github.com/XuehaiPan/nvitop/commit/d846500d8bf28a9160f864541b7b7a05119d31b0) feat(gui): add global attribute - [`53fe991`](https://github.com/XuehaiPan/nvitop/commit/53fe9918ff026589012f0649bd44b4d1538d49d9) chore(gui/help): update help screen - [`055dc9a`](https://github.com/XuehaiPan/nvitop/commit/055dc9aff5a3c08abc91ced51056c83ad010a666) chore(gui): dim not owned processes - [`187d650`](https://github.com/XuehaiPan/nvitop/commit/187d650539134d7f8db1ae8050b7839c79f675c0) chore(gui): update preserved colors - [`c1be779`](https://github.com/XuehaiPan/nvitop/commit/c1be7792cef1fd62e7348d7735387b6238cd7262) chore(gui): update selection reseting - [`387f8d1`](https://github.com/XuehaiPan/nvitop/commit/387f8d199431a9c2af47bef1fb197b4687d6a6d9) docs: update screenshot for help screen - [`f106a29`](https://github.com/XuehaiPan/nvitop/commit/f106a29806d3110a763826738386a124b0d72f82) style: resolve pylint warnings ### 📊 Changes **18 files changed** (+254 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yaml` (+7 -1) 📝 `README.md` (+2 -1) 📝 `nvitop/core/device.py` (+16 -7) 📝 `nvitop/core/libnvml.py` (+2 -2) 📝 `nvitop/gui/library/history.py` (+1 -1) 📝 `nvitop/gui/library/libcurses.py` (+20 -5) 📝 `nvitop/gui/screens/environ.py` (+1 -1) 📝 `nvitop/gui/screens/help.py` (+7 -7) 📝 `nvitop/gui/screens/main/__init__.py` (+20 -15) 📝 `nvitop/gui/screens/main/device.py` (+9 -4) 📝 `nvitop/gui/screens/main/host.py` (+2 -2) 📝 `nvitop/gui/screens/main/process.py` (+44 -22) 📝 `nvitop/gui/screens/main/utils.py` (+45 -28) 📝 `nvitop/gui/screens/treeview.py` (+57 -27) 📝 `nvitop/gui/top.py` (+8 -6) 📝 `nvitop/version.py` (+11 -2) 📝 `pyproject.toml` (+1 -1) 📝 `requirements.txt` (+1 -1) </details> ### 📄 Description #### Issue Type <!-- Pick relevant types and delete the rest --> - Improvement/feature implementation #### Runtime Environment <!-- Details of your runtime environment --> - Operating system and version: Ubuntu 20.04 LTS - Terminal emulator and version: GNOME Terminal 3.36.2 - Python version: `3.9.13` - NVML version (driver version): `470.129.06` - `nvitop` version or commit: `v0.7.1` - `python-ml-py` version: `11.450.51` - Locale: `en_US.UTF-8` #### Description <!-- Describe the changes in detail --> Add process tagging support to the main and tree-view screens. Now the user can select multiple processes and kill them in a single `K` keystroke. #### Motivation and Context <!-- Why are these changes required? --> <!-- What problems do these changes solve? --> <!-- Link to relevant issues --> Select multiple processes and kill them in a single `K` keystroke, rather than kill processes one by one. #### Testing N/A #### Images / Videos <!-- Only if relevant --> <!-- Link or embed images and videos of screenshots, sketches etc. --> Process tagging on the main screen: <img width="1034" alt="main" src="https://user-images.githubusercontent.com/16078332/188309601-ef2ff4c7-ecde-4aec-96d0-d810e72dbb5a.png"> Process tagging on the tree-view screen: <img width="1034" alt="tree-view" src="https://user-images.githubusercontent.com/16078332/188309619-eea26444-d662-4b79-9634-506367233128.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:26:27 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/nvitop#131
No description provided.