mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 22:02:06 -06:00
[GH-ISSUE #65] Add support for OpenBSD #57
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#57
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @edgarpettijohn on GitHub (Jul 12, 2016).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/65
Originally assigned to: @jmcnamara on GitHub.
Here are my patches to build on OpenBSD 6.0 with no errors/warnings. Please review and include in src distribution. I haven't gotten a chance to really play around with the lib yet, but all of the examples I've looked at and built, etc seem to work well and are easy to follow. It reminds me of GTK+.
libpatch.txt
Thanks!
@jmcnamara commented on GitHub (Jul 12, 2016):
Hi Edgar,
Thanks for that. It is good to support another OS. I'll merge the changes up in the next few days.
One question. Are the patches to
miniunz.candminizip.cactually required? They aren't used by libxlsxwriter and are only included since they are part of the minizip component from zlib.Thanks for your contribution.
John
@edgarpettijohn commented on GitHub (Jul 12, 2016):
Sent from my iPhone
I'll have to check. I just took a knife to everything fseeko64 related.
Edgar
@edgarpettijohn commented on GitHub (Jul 12, 2016):
I think the problem is that there is no way to tell the Makefile that I want to use my systems zlib. Or I'm missing something. Looks like I can just as easily pass -DIOAPI_NO_64 to clear up fseeko64 problems with no intervention on your part.
Edgar
@jmcnamara commented on GitHub (Jul 12, 2016):
Hi Edgar,
I've set up an OpenBSD system for testing and I've pushed up a few fixes for the issues you pointed out and a few other warnings from the unit test suite. You can try it when you get a chance.
I didn't have to install the zlib dev libraries at all which is nice.
I'm building Python at the moment (pkg_add failed to install any of the Python versions for some reason). Once it is done I'll check if everything is okay in functional test suite.
John
@jmcnamara commented on GitHub (Jul 13, 2016):
I got Python installed and working and the test suite passes on OpenBSD 5.9. There are a few more warnings, that I don't see on other systems, to get rid off but they are mostly harmless.
@edgarpettijohn commented on GitHub (Jul 13, 2016):
Thats what I assumed. I built all of the examples and they seemed to work properly, so I wasn't going to dig into the tests.
@edgarpettijohn commented on GitHub (Jul 13, 2016):
builds without error/warnings.
@jmcnamara commented on GitHub (Jul 13, 2016):
Great. Thanks for letting me know and for pointing out the issue in the first place.
@edgarpettijohn commented on GitHub (Jul 14, 2016):
As far as packaging goes. I would rather follow releases. When do you expect to have another release? If its a ways off I'll figure something out.
@jmcnamara commented on GitHub (Jul 14, 2016):
Hi Edgar,
I pushed a new release, 0.4.2, with the OpenBSD fixes just a short while ago: http://libxlsxwriter.github.io/changes.html
Closing, thanks.
John