github-starred/libxlsxwriter
2
0
Fork 0
mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00
Code Issues 16 Projects Packages Wiki Activity Actions

[GH-ISSUE #57] Warning about redefinition of SLIST_ENTRY #46

New issue
Closed
opened 2026-05-05 11:31:05 -06:00 by gitea-mirror · 5 comments
gitea-mirror commented 2026-05-05 11:31:05 -06:00
Owner
Copy link

Originally created by @utelle on GitHub (Jun 29, 2016).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/57

Originally assigned to: @jmcnamara on GitHub.

The source file packager.c includes the header file windows.h. At least using Visual C++ 2010 I get a warning that the symbol SLIST_ENTRY is redefined in header file winnt.h which is indirectly included by windows.h. It's just a warning and the symbol is not used in packager.c, so no harm is done. However, it might be a good idea to rename the symbol in libxlsxwriter to something else to avoid name clashes (and thus potential problems).

Originally created by @utelle on GitHub (Jun 29, 2016). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/57 Originally assigned to: @jmcnamara on GitHub. The source file `packager.c` includes the header file `windows.h`. At least using Visual C++ 2010 I get a warning that the symbol `SLIST_ENTRY` is redefined in header file `winnt.h` which is indirectly included by `windows.h`. It's just a warning and the symbol is not used in `packager.c`, so no harm is done. However, it might be a good idea to rename the symbol in `libxlsxwriter` to something else to avoid name clashes (and thus potential problems).
gitea-mirror 2026-05-05 11:31:05 -06:00
  • closed this issue
  • added the
    question
         label
gitea-mirror commented 2026-05-05 11:31:15 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (Jun 29, 2016):

Hi Ulrich,

I don't see that warning using this project in MSVC 2013.

The SLIST_ENTRY is a macro definition of a struct and it comes from the FreeBSD/Linux header queue.h which is included with libxlsxwriter.

So I think you will just have to live with this warning in MSVC 2010.

John

<!-- gh-comment-id:229312634 --> @jmcnamara commented on GitHub (Jun 29, 2016): Hi Ulrich, I don't see that warning using this [project ](https://github.com/jmcnamara/MSVCLibXlsxWriter)in MSVC 2013. The `SLIST_ENTRY` is a macro definition of a struct and it comes from the FreeBSD/Linux header `queue.h` which is included with libxlsxwriter. So I think you will just have to live with this warning in MSVC 2010. John
gitea-mirror commented 2026-05-05 11:31:19 -06:00
Author
Owner
Copy link

@utelle commented on GitHub (Jun 29, 2016):

Interesting. Maybe this warning is related to the Windows SDK in use - which might be different for MSVC 2013.

Some googling reveals that other projects seem to be affected, too. Some define a different symbol to avoid the warning. I also found a version of queue.h, which explicitly undefines the symbol before redefining it. However, the latter only works if windows.h is included before queue.h. For libxlsxwriter this would currently not work, since windows.h is included afterwards.

Personally, I can live with the warning. So feel free to close this issue.

<!-- gh-comment-id:229337706 --> @utelle commented on GitHub (Jun 29, 2016): Interesting. Maybe this warning is related to the Windows SDK in use - which might be different for MSVC 2013. Some googling reveals that other projects seem to be affected, too. Some define a different symbol to avoid the warning. I also found a version of [queue.h](https://searchcode.com/codesearch/view/11905748/), which explicitly undefines the symbol before redefining it. However, the latter only works if `windows.h` is included **before** `queue.h`. For `libxlsxwriter` this would currently not work, since `windows.h` is included **afterwards**. Personally, I can live with the warning. So feel free to close this issue.
gitea-mirror commented 2026-05-05 11:31:23 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (Jun 29, 2016):

Okay. Thanks for the followup. Closing.

<!-- gh-comment-id:229341955 --> @jmcnamara commented on GitHub (Jun 29, 2016): Okay. Thanks for the followup. Closing.
gitea-mirror commented 2026-05-05 11:31:27 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (Jul 3, 2016):

Hi,

I pushed a fix for this warning to master. Basically it undefs the macro before including windows.h.

When you get a chance you can try it and let me know if it fixes the warning on Windows.

John

<!-- gh-comment-id:230152847 --> @jmcnamara commented on GitHub (Jul 3, 2016): Hi, I pushed a fix for this warning to master. Basically it undefs the macro before including `windows.h`. When you get a chance you can try it and let me know if it fixes the warning on Windows. John
gitea-mirror commented 2026-05-05 11:31:28 -06:00
Author
Owner
Copy link

@utelle commented on GitHub (Jul 3, 2016):

Yes, this eliminates the warning.

<!-- gh-comment-id:230165658 --> @utelle commented on GitHub (Jul 3, 2016): Yes, this eliminates the warning.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
coverity
cmake-improvements
cmake_pkgconfig_fix
ctest
button
tables
autofilter
dtoa
iwyu
openssl
gentoo
gh310
condition_format
rich_string_html
header_footer_images
custom_data_labels
object_position
gh265
constant_mode_comments2
constant_mode_comments
vml
md5
vcpkg
hyperlinks
api_refactor
win_fopen
gh203
rich_strings
chartsheet
in_mem_image
gh192
revert-162-master
data_validation
meson
charts
scan_build
utf8_strlen
tmpfileplus
custom_properties
insert_image
default_row
control_chars
worksheet_protect
dev
red_black
panes
mkstemp
defined_names
optimise
wip
v1.2.4
v1.2.3
v1.2.2
v1.2.1
v1.2.0
v1.1.9
v1.1.8
RELEASE_1.1.7
RELEASE_1.1.6
RELEASE_1.1.5
RELEASE_1.1.4
RELEASE_1.1.3
RELEASE_1.1.2
RELEASE_1.1.1
RELEASE_1.1.0
RELEASE_1.0.9
RELEASE_1.0.8
RELEASE_1.0.7
RELEASE_1.0.6
RELEASE_1.0.5
RELEASE_1.0.4
RELEASE_1.0.3
RELEASE_1.0.2
RELEASE_1.0.1
RELEASE_1.0.0
RELEASE_0.9.9
RELEASE_0.9.8
RELEASE_0.9.7
RELEASE_0.9.6
RELEASE_0.9.5
RELEASE_0.9.4
RELEASE_0.9.3
RELEASE_0.9.2
RELEASE_0.9.1
RELEASE_0.9.0
RELEASE_0.8.9
RELEASE_0.8.8
RELEASE_0.8.7
RELEASE_0.8.6
RELEASE_0.8.5
RELEASE_0.8.4
RELEASE_0.8.3
RELEASE_0.8.2
RELEASE_0.8.1
RELEASE_0.8.0
RELEASE_0.7.9
RELEASE_0.7.8
RELEASE_0.7.7
RELEASE_0.7.6
RELEASE_0.7.5
RELEASE_0.7.4
RELEASE_0.7.3
RELEASE_0.7.2
RELEASE_0.7.1
RELEASE_0.7.0
RELEASE_0.6.9
RELEASE_0.6.8
RELEASE_0.6.7
RELEASE_0.6.6
RELEASE_0.6.5
RELEASE_0.6.4
RELEASE_0.6.3
RELEASE_0.6.2
RELEASE_0.6.1
RELEASE_0.6.0
RELEASE_0.5.9
RELEASE_0.5.8
RELEASE_0.5.7
RELEASE_0.5.6
RELEASE_0.5.5
RELEASE_0.5.4
RELEASE_0.5.3
RELEASE_0.5.2
RELEASE_0.5.1
RELEASE_0.5.0
RELEASE_0.4.9
RELEASE_0.4.8
RELEASE_0.4.7
RELEASE_0.4.6
RELEASE_0.4.5
RELEASE_0.4.4
RELEASE_0.4.3
RELEASE_0.4.2
RELEASE_0.4.1
RELEASE_0.4.0
RELEASE_0.3.9
RELEASE_0.3.8
RELEASE_0.3.7
RELEASE_0.3.6
RELEASE_0.3.5
RELEASE_0.3.4
RELEASE_0.3.3
RELEASE_0.3.2
RELEASE_0.3.1
RELEASE_0.3.0
RELEASE_0.2.9
RELEASE_0.2.8
RELEASE_0.2.7
RELEASE_0.2.6
RELEASE_0.2.5
RELEASE_0.2.4
RELEASE_0.2.3
RELEASE_0.2.2
RELEASE_0.2.1
RELEASE_0.2.0
RELEASE_0.1.9
RELEASE_0.1.8
RELEASE_0.1.7
RELEASE_0.1.6
RELEASE_0.1.5
RELEASE_0.1.4
RELEASE_0.1.3
RELEASE_0.1.2
RELEASE_0.1.1
RELEASE_0.1.0
RELEASE_0.0.9
RELEASE_0.0.8
RELEASE_0.0.7
RELEASE_0.0.6
RELEASE_0.0.5
RELEASE_0.0.4
RELEASE_0.0.3
RELEASE_0.0.2
RELEASE_0.0.1
Labels
Clear labels   
awaiting user feedback

   
bug

   
cmake

   
cmake

   
docs

   
feature request

   
in progress

   
long term

   
medium term

   
medium term

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question

   
ready to close

   
short term

   
under investigation

   
wontfix
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/libxlsxwriter#46
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?