[PR #414] [CLOSED] Compatibility with Visual Studio and MS C compiler #486

New issue

Closed

opened 2026-05-05 12:17:13 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:17:13 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/414
Author: @HolgiHo
Created: 9/18/2023
Status: ❌ Closed

Base: main ← Head: visual_studio_compatibility

📝 Commits (1)

acf24b7 compatibility with Visual Studio and MS C compiler

📊 Changes

4 files changed (+74 additions, -12 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 include/xlsxwriter/worksheet.h (+3 -3)
📝 src/worksheet.c (+2 -2)
📝 test/unit/ctest.h (+67 -7)

📄 Description

PR for issue #413

Fix unit tests:

ctest.h: make unit test registration and iteration work: use linker segments .ctest$a, .ctest$b, .ctest$c

Additional fixes for building with VS:

fix build error in VS: use const char* in struct lxw_header_footer_options, _worksheet_set_header_footer_image
extend .gitignore to ignore special local VS directories/files

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/414 **Author:** [@HolgiHo](https://github.com/HolgiHo) **Created:** 9/18/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `visual_studio_compatibility` --- ### 📝 Commits (1) - [`acf24b7`](https://github.com/jmcnamara/libxlsxwriter/commit/acf24b7d7196c54b9f28bb16b8bbf1195bf0b8fe) compatibility with Visual Studio and MS C compiler ### 📊 Changes **4 files changed** (+74 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `include/xlsxwriter/worksheet.h` (+3 -3) 📝 `src/worksheet.c` (+2 -2) 📝 `test/unit/ctest.h` (+67 -7) </details> ### 📄 Description PR for issue #413 Fix unit tests: - `ctest.h`: make unit test registration and iteration work: use linker segments `.ctest$a`, `.ctest$b`, `.ctest$c` Additional fixes for building with VS: - fix build error in VS: use `const char*` in struct `lxw_header_footer_options`, `_worksheet_set_header_footer_image` - extend `.gitignore` to ignore special local VS directories/files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>