[PR #94] [CLOSED] Fix including xlsxwriter as a CocoaPod on macOS. #414

New issue

Closed

opened 2026-05-05 12:15:15 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:15 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/94
Author: @MrMage
Created: 2/21/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (7)

fd56244 Fix including xlsxwriter as a CocoaPod on macOS.
33007b8 Minor documentation fix.
903068e Merge branch 'master' of https://github.com/jmcnamara/libxlsxwriter
66c378c Merge branch 'master' of https://github.com/jmcnamara/libxlsxwriter
4ddf376 Add a static-library CocoaPod variant as a subspec.
8460d61 Augment the summary of the 'StaticLibrary' CocoaPod.
a7e37dc Remove the StaticLibrary podspecs again - turns out CocoaPods doesn't like subspecs overriding the module map.

📊 Changes

6 files changed (+6 additions, -156 deletions)

View changed files

➖ License.txt (+0 -150)
📝 cocoapods/libxlsxwriter-umbrella.h (+1 -1)
📝 cocoapods/libxlsxwriter.modulemap (+2 -2)
📝 include/xlsxwriter/workbook.h (+1 -1)
📝 include/xlsxwriter/worksheet.h (+1 -1)
📝 libxlsxwriter.podspec (+1 -1)

📄 Description

Explanation for this change:

Previously, CocoaPods would set up the framework target such that xlsxwriter.h would appear in the framework's main directory, alongside the xlsxwriter binary. It appears that the codesign utility only expects binaries in that directory, though, with all headers being in the Headers subdirectory (otherwise it fails with an xlsxwriter.h: code object is not signed at all message). This change modifies the header_mappings_dir to ensure that xlsxwriter.h is in Headers, with all other headers in Headers/xlsxwriter, and adjusts the paths in the module map accordingly.

In addition, the umbrella header is modified to include Foundation rather than UIKit, as the former is sufficient to compile the module while the latter is not available on macOS.

This change fixes compiling, signing and linking with the module on my macOS target. However, I haven't reviewed its correctness for iOS or other implications (although I would expect everything to work), so please review these four lines carefully ;-)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/94 **Author:** [@MrMage](https://github.com/MrMage) **Created:** 2/21/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`fd56244`](https://github.com/jmcnamara/libxlsxwriter/commit/fd562445fdd0e01cb84d74563e4fd3ca4e22f978) Fix including xlsxwriter as a CocoaPod on macOS. - [`33007b8`](https://github.com/jmcnamara/libxlsxwriter/commit/33007b82c8fb903955182f2eafff73408bba0ac3) Minor documentation fix. - [`903068e`](https://github.com/jmcnamara/libxlsxwriter/commit/903068e405fe7326564096fed37b134883075d2f) Merge branch 'master' of https://github.com/jmcnamara/libxlsxwriter - [`66c378c`](https://github.com/jmcnamara/libxlsxwriter/commit/66c378c74a5166da164d2677af62eca5cd39d21e) Merge branch 'master' of https://github.com/jmcnamara/libxlsxwriter - [`4ddf376`](https://github.com/jmcnamara/libxlsxwriter/commit/4ddf3760ebefc397051457860eefc3963de5eae0) Add a static-library CocoaPod variant as a subspec. - [`8460d61`](https://github.com/jmcnamara/libxlsxwriter/commit/8460d6121f8a096b120411d9c7b288bc98d9c95e) Augment the summary of the 'StaticLibrary' CocoaPod. - [`a7e37dc`](https://github.com/jmcnamara/libxlsxwriter/commit/a7e37dcff090ce02f7531ae5c8061879a2200e02) Remove the StaticLibrary podspecs again - turns out CocoaPods doesn't like subspecs overriding the module map. ### 📊 Changes **6 files changed** (+6 additions, -156 deletions) <details> <summary>View changed files</summary> ➖ `License.txt` (+0 -150) 📝 `cocoapods/libxlsxwriter-umbrella.h` (+1 -1) 📝 `cocoapods/libxlsxwriter.modulemap` (+2 -2) 📝 `include/xlsxwriter/workbook.h` (+1 -1) 📝 `include/xlsxwriter/worksheet.h` (+1 -1) 📝 `libxlsxwriter.podspec` (+1 -1) </details> ### 📄 Description Explanation for this change: Previously, CocoaPods would set up the framework target such that `xlsxwriter.h` would appear in the framework's main directory, alongside the `xlsxwriter` binary. It appears that the `codesign` utility only expects binaries in that directory, though, with all headers being in the `Headers` subdirectory (otherwise it fails with an `xlsxwriter.h: code object is not signed at all` message). This change modifies the header_mappings_dir to ensure that `xlsxwriter.h` is in `Headers`, with all other headers in `Headers/xlsxwriter`, and adjusts the paths in the module map accordingly. In addition, the umbrella header is modified to include Foundation rather than UIKit, as the former is sufficient to compile the module while the latter is not available on macOS. This change fixes compiling, signing and linking with the module on my macOS target. However, I haven't reviewed its correctness for iOS or other implications (although I would expect everything to work), so please review these four lines carefully ;-) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>