[PR #129] [MERGED] Patch for #115 and Patches for MSVC Shared Builds #422

New issue

Closed

opened 2026-05-05 12:15:30 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:30 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/129
Author: @Alexhuszagh
Created: 10/20/2017
Status: ✅ Merged
Merged: 10/22/2017
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (1)

6c7c15a Bug fixes for CMakeLists and CI for the CMakelists to patch #115

📊 Changes

3 files changed (+71 additions, -29 deletions)

View changed files

📝 .drone.yml (+11 -3)
📝 CMakeLists.txt (+26 -19)
📝 appveyor.yml (+34 -7)

📄 Description

Fixes:

Missing DLL installation on Windows
Missing exported symbols on MSVC when creating a DLL.
Increases the number of configurations for MinGW and MSVC CI to ensure static/shared builds, with more platforms and build types.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/129 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 10/20/2017 **Status:** ✅ Merged **Merged:** 10/22/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6c7c15a`](https://github.com/jmcnamara/libxlsxwriter/commit/6c7c15a9786721c6db8325e28203ca0c5c014677) Bug fixes for CMakeLists and CI for the CMakelists to patch #115 ### 📊 Changes **3 files changed** (+71 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `.drone.yml` (+11 -3) 📝 `CMakeLists.txt` (+26 -19) 📝 `appveyor.yml` (+34 -7) </details> ### 📄 Description Fixes: - Missing DLL installation on Windows - Missing exported symbols on MSVC when creating a DLL. - Increases the number of configurations for MinGW and MSVC CI to ensure static/shared builds, with more platforms and build types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>