[PR #103] [MERGED] improve cmake file for MSVC #419

New issue

Closed

opened 2026-05-05 12:15:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/103
Author: @jimzshi
Created: 4/20/2017
Status: ✅ Merged
Merged: 4/24/2017
Merged by: @jmcnamara

Base: master ← Head: msvc_cmake

📝 Commits (1)

9a78c32 improve cmake file for MSVC

📊 Changes

2 files changed (+52 additions, -20 deletions)

View changed files

📝 CMakeLists.txt (+49 -18)
📝 cmake/FindZLIB.cmake (+3 -2)

📄 Description

optional project and binary name
optimize output folder tree for MSVC configurations
fix compiler flags issues for MSVC
fix minor issue when findzlib

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/103 **Author:** [@jimzshi](https://github.com/jimzshi) **Created:** 4/20/2017 **Status:** ✅ Merged **Merged:** 4/24/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `msvc_cmake` --- ### 📝 Commits (1) - [`9a78c32`](https://github.com/jmcnamara/libxlsxwriter/commit/9a78c323a925c75d8feffb7c3f6a7773e79d2628) improve cmake file for MSVC ### 📊 Changes **2 files changed** (+52 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+49 -18) 📝 `cmake/FindZLIB.cmake` (+3 -2) </details> ### 📄 Description - optional project and binary name - optimize output folder tree for MSVC configurations - fix compiler flags issues for MSVC - fix minor issue when findzlib --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>