[GH-ISSUE #123] LICENSE.txt is missing tmpfileplus and tree.h #103

New issue

Closed

opened 2026-05-05 11:41:02 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 11:41:02 -06:00

Owner

Originally created by @jeroen on GitHub (Aug 29, 2017).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/123

Originally assigned to: @jmcnamara on GitHub.

I'm having a hard time publishing my bindings because the comments contain several copyright holders which are not mentioned in the license.

Originally created by @jeroen on GitHub (Aug 29, 2017). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/123 Originally assigned to: @jmcnamara on GitHub. I'm having a hard time publishing my bindings because the comments contain several copyright holders which are not mentioned in the license.

gitea-mirror

2026-05-05 11:41:02 -06:00

closed this issue
added the
bug

docs
labels

gitea-mirror commented

2026-05-05 11:41:09 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 29, 2017):

The full list of licences are included in the doc sources and rendered in the on-line docs.

However, the LICENSE.txt file isn't up to date with the doc file (I thought that I had linked them like the Changes file). So I'll fix that.

For now refer to the License file in the docs.

@jmcnamara commented on GitHub (Aug 29, 2017): The full list of licences are included in the [doc sources](https://github.com/jmcnamara/libxlsxwriter/blob/master/docs/src/license.dox) and rendered in the [on-line docs](https://libxlsxwriter.github.io/license.html). However, the LICENSE.txt file isn't up to date with the doc file (I thought that I had linked them like the Changes file). So I'll fix that. For now refer to the [License file](https://github.com/jmcnamara/libxlsxwriter/blob/master/docs/src/license.dox) in the docs.

gitea-mirror commented

2026-05-05 11:41:12 -06:00

Author

Owner

@jeroen commented on GitHub (Aug 29, 2017):

OK thanks. My distro maintainers still complain about these lines in the source code:

  Copyright (C) 1998-2010 Gilles Vollant (minizip) ( http://www.winimage.com/zLibDll/minizip.html )
  Copyright (C) 2009-2010 Mathias Svensson ( http://result42.com )

These names are not named in the license. Their policy is that any author with a Copyright or (C) line in the source code must be mentioned somewhere in the license. Perhaps add st like this:

[MiniZip](http://www.winimage.com/zLibDll/minizip.html) (part of zlib)

   Copyright (C) 1998-2010 Gilles Vollant
   Copyright (C) 2009-2010 Mathias Svensson ( http://result42.com )
   Condition of use and distribution are the same than zlib (above).

I think it's silly because this is part of zlib, but I need to add this, so do with that what you like.

@jeroen commented on GitHub (Aug 29, 2017): OK thanks. My distro maintainers still complain about these lines in the source code: ``` Copyright (C) 1998-2010 Gilles Vollant (minizip) ( http://www.winimage.com/zLibDll/minizip.html ) Copyright (C) 2009-2010 Mathias Svensson ( http://result42.com ) ``` These names are not named in the license. Their policy is that any author with a `Copyright` or `(C) ` line in the source code must be mentioned somewhere in the license. Perhaps add st like this: ``` [MiniZip](http://www.winimage.com/zLibDll/minizip.html) (part of zlib) Copyright (C) 1998-2010 Gilles Vollant Copyright (C) 2009-2010 Mathias Svensson ( http://result42.com ) Condition of use and distribution are the same than zlib (above). ``` I think it's silly because this is part of zlib, but I need to add this, so do with that what you like.

gitea-mirror commented

2026-05-05 11:41:16 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 30, 2017):

I've created a single License file shared between the src tree and the docs with the minizip contributions called out.

Note, if you are confident that the system you are targeting already have a minizip library you can compile libxlsxwriter without it and probably drop that part of the copyright/licence. The same applies for tempfileplus.

However, the header files are still installed with libxlsxwriter if you do make install. I'll fix that shortly.

@jmcnamara commented on GitHub (Aug 30, 2017): I've created a single License file shared between the src tree and the docs with the minizip contributions called out. Note, if you are confident that the system you are targeting already have a minizip library you can [compile libxlsxwriter without it](http://libxlsxwriter.github.io/getting_started.html#gsg_minizip) and probably drop that part of the copyright/licence. The same applies for tempfileplus. However, the header files are still installed with libxlsxwriter if you do `make install`. I'll fix that shortly.

gitea-mirror commented

2026-05-05 11:41:19 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 30, 2017):

Also, unrelated to this but so you know, if you are using libxlsxwriter on systems with LANG settings that change the locale to one that uses a comma as a decimal point then you will run into issues. See #64.

@jmcnamara commented on GitHub (Aug 30, 2017): Also, unrelated to this but so you know, if you are using libxlsxwriter on systems with LANG settings that change the locale to one that uses a comma as a decimal point then you will run into issues. See #64.

gitea-mirror referenced this issue

2026-05-05 12:15:22 -06:00

[PR #103] [MERGED] improve cmake file for MSVC #419