github-starred/libxlsxwriter

Fork 0

mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00

[GH-ISSUE #274] Incorrect image height #218

New issue

Closed

opened 2026-05-05 11:57:26 -06:00 by gitea-mirror · 8 comments

gitea-mirror commented

2026-05-05 11:57:26 -06:00

Owner

Originally created by @RaFaeL-NN on GitHub (Feb 29, 2020).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/274

Originally assigned to: @jmcnamara on GitHub.

examples\images.c

lxw_workbook  *workbook  = workbook_new("images.xlsx");
lxw_worksheet *worksheet = workbook_add_worksheet(workbook, NULL);
worksheet_insert_image(worksheet, CELL("B2"), "logo.png");    
workbook_close(workbook);  `

Height is 103%. Why?

0.6 scale -> 63%, and so on. 1.1 -> 116%.
But 0.5 scaling is correct, but 0.5 only

Originally created by @RaFaeL-NN on GitHub (Feb 29, 2020). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/274 Originally assigned to: @jmcnamara on GitHub. examples\images.c ` lxw_workbook *workbook = workbook_new("images.xlsx"); lxw_worksheet *worksheet = workbook_add_worksheet(workbook, NULL); worksheet_insert_image(worksheet, CELL("B2"), "logo.png"); workbook_close(workbook); ` Height is 103%. Why? ![images](https://user-images.githubusercontent.com/34895749/75614974-42d4ae80-5b4f-11ea-988e-92c0c26e8d3e.png) 0.6 scale -> 63%, and so on. 1.1 -> 116%. But 0.5 scaling is correct, but 0.5 only

gitea-mirror

2026-05-05 11:57:26 -06:00

closed this issue
added the
question

awaiting user feedback
labels

gitea-mirror commented

2026-05-05 11:57:34 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 29, 2020):

Could you attach the image you are using

@jmcnamara commented on GitHub (Feb 29, 2020): Could you attach the image you are using

gitea-mirror commented

2026-05-05 11:57:39 -06:00

Author

Owner

@RaFaeL-NN commented on GitHub (Feb 29, 2020):

images.zip

@RaFaeL-NN commented on GitHub (Feb 29, 2020): [images.zip](https://github.com/jmcnamara/libxlsxwriter/files/4271059/images.zip)

gitea-mirror commented

2026-05-05 11:57:44 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 29, 2020):

It looks okay in my version of Excel when I run this program (same as your with the filename and image renamed):


#include "xlsxwriter.h"

int main() {
    lxw_workbook  *workbook  = workbook_new("gh274.xlsx");
    lxw_worksheet *worksheet = workbook_add_worksheet(workbook, NULL);

    worksheet_insert_image(worksheet, CELL("B2"), "gh274.png");

    workbook_close(workbook);

    return 0;
}

Output:

What happens when you manually insert that image into Excel? What dimensions do you get?

@jmcnamara commented on GitHub (Feb 29, 2020): It looks okay in my version of Excel when I run this program (same as your with the filename and image renamed): ```C #include "xlsxwriter.h" int main() { lxw_workbook *workbook = workbook_new("gh274.xlsx"); lxw_worksheet *worksheet = workbook_add_worksheet(workbook, NULL); worksheet_insert_image(worksheet, CELL("B2"), "gh274.png"); workbook_close(workbook); return 0; } ```` Output: ![Screenshot 2020-02-29 at 23 15 59](https://user-images.githubusercontent.com/94267/75616499-bd9acb00-5b49-11ea-98a8-536f681be845.png) What happens when you manually insert that image into Excel? What dimensions do you get?

gitea-mirror commented

2026-05-05 11:57:48 -06:00

Author

Owner

@RaFaeL-NN commented on GitHub (Mar 1, 2020):

I found an issue. _worksheet_size_row returns 19 instead of 20. I change


        if (row) {
        if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER)
            pixels = 0;
        else
            pixels = (uint32_t) (4.0 / 3.0 * row->height);
    }
    else {
        pixels = (uint32_t) (4.0 / 3.0 * self->default_row_height);
    }


       if (row) {
        if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER)
            pixels = 0;
        else
            pixels = (uint32_t) (row->height * 4.0 / 3.0);
    }
    else {
        pixels = (uint32_t) (self->default_row_height * 4.0 / 3.0);
    }

and it works correct now for me. I don't know a nature of this issue (old compiler, compiling options or smth other) but I hope you'll apply this patch too

@RaFaeL-NN commented on GitHub (Mar 1, 2020): I found an issue. _worksheet_size_row returns 19 instead of 20. I change ```C if (row) { if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER) pixels = 0; else pixels = (uint32_t) (4.0 / 3.0 * row->height); } else { pixels = (uint32_t) (4.0 / 3.0 * self->default_row_height); } ``` to ```C if (row) { if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER) pixels = 0; else pixels = (uint32_t) (row->height * 4.0 / 3.0); } else { pixels = (uint32_t) (self->default_row_height * 4.0 / 3.0); } ``` and it works correct now for me. I don't know a nature of this issue (old compiler, compiling options or smth other) but I hope you'll apply this patch too

gitea-mirror commented

2026-05-05 11:57:52 -06:00

Author

Owner

@jmcnamara commented on GitHub (Mar 1, 2020):

I found an issue. _worksheet_size_row returns 19 instead of 20

Good find. Does the following work? It may be more explicit. The 4.0/3.0 actually comes from the ratio of DPIs 96.0/72.0:

        if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER)
            pixels = 0;
        else
            pixels = (uint32_t) (0.75 * row->height);
    }
    else {
        pixels = (uint32_t) (0.75 * self->default_row_height);
    }

@jmcnamara commented on GitHub (Mar 1, 2020): > I found an issue. _worksheet_size_row returns 19 instead of 20 Good find. Does the following work? It may be more explicit. The `4.0/3.0` actually comes from the ratio of DPIs `96.0/72.0`: ```C if (row->hidden && anchor != LXW_OBJECT_MOVE_AND_SIZE_AFTER) pixels = 0; else pixels = (uint32_t) (0.75 * row->height); } else { pixels = (uint32_t) (0.75 * self->default_row_height); } ```

gitea-mirror commented

2026-05-05 11:57:53 -06:00

Author

Owner

@RaFaeL-NN commented on GitHub (Mar 1, 2020):

Do you mean (row->height) / 0.75 ? 4/3=1.3(3)

I check, row->height / 0.75 works too

@RaFaeL-NN commented on GitHub (Mar 1, 2020): Do you mean (row->height) / 0.75 ? 4/3=1.3(3) I check, row->height / 0.75 works too

gitea-mirror commented

2026-05-05 11:57:57 -06:00

Author

Owner

@jmcnamara commented on GitHub (Mar 1, 2020):

I check, row->height / 0.75 works too

Good, thanks. I’ll probably go with that.

@jmcnamara commented on GitHub (Mar 1, 2020): > I check, row->height / 0.75 works too Good, thanks. I’ll probably go with that.

gitea-mirror commented

2026-05-05 11:58:00 -06:00

Author

Owner

@jmcnamara commented on GitHub (Mar 21, 2020):

Ok. Thanks. Fixed on master.

@jmcnamara commented on GitHub (Mar 21, 2020): Ok. Thanks. Fixed on master.