github-starred/libxlsxwriter
2
0
Fork 0
mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00
Code Issues 16 Projects Packages Wiki Activity Actions

[GH-ISSUE #227] ZIP errors are not specified #183

New issue
Closed
opened 2026-05-05 11:50:52 -06:00 by gitea-mirror · 6 comments
gitea-mirror commented 2026-05-05 11:50:52 -06:00
Owner
Copy link

Originally created by @evanmiller on GitHub (May 14, 2019).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/227

Originally assigned to: @jmcnamara on GitHub.

I am getting an error when creating a large XLSX file (2,000+ columns, 100,000+ rows).

[ERROR][/Code/libxlsxwriter/src/packager.c:1103]: Error in closing member in the zipfile
[ERROR] workbook_close(): Zlib error adding file to xlsx file '/private/tmp/Albania - Estonia.xlsx'.

The logic of RETURN_ON_ZIP_ERROR indicates that the error is not ZIP_ERRNO (née Z_ERRNO) - however, I do not know what the actual error code is. Any way to bubble this up so I can access it from client code?

Originally created by @evanmiller on GitHub (May 14, 2019). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/227 Originally assigned to: @jmcnamara on GitHub. I am getting an error when creating a large XLSX file (2,000+ columns, 100,000+ rows). ``` [ERROR][/Code/libxlsxwriter/src/packager.c:1103]: Error in closing member in the zipfile [ERROR] workbook_close(): Zlib error adding file to xlsx file '/private/tmp/Albania - Estonia.xlsx'. ``` The logic of `RETURN_ON_ZIP_ERROR` indicates that the error is not `ZIP_ERRNO` (née `Z_ERRNO`) - however, I do not know what the actual error code is. Any way to bubble this up so I can access it from client code?
gitea-mirror 2026-05-05 11:50:52 -06:00
gitea-mirror commented 2026-05-05 11:51:00 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (May 15, 2019):

Any way to bubble this up so I can access it from client code?

Not without remapping all the zlib error codes. There are only 6 so that is probably doable. However, the zlib error codes aren't hugely informative either so they probably wouldn't be very useful to you anyway. See: https://www.zlib.net/manual.html

<!-- gh-comment-id:492608950 --> @jmcnamara commented on GitHub (May 15, 2019): > Any way to bubble this up so I can access it from client code? Not without remapping all the zlib error codes. There are only 6 so that is probably doable. However, the zlib error codes aren't hugely informative either so they probably wouldn't be very useful to you anyway. See: https://www.zlib.net/manual.html
gitea-mirror commented 2026-05-05 11:51:01 -06:00
Author
Owner
Copy link

@evanmiller commented on GitHub (May 15, 2019):

Distinct from the Zlib errors there are the ZIP errors, which would help me narrow down the offending code path.

b616fb59ff/include/xlsxwriter/third_party/zip.h (L88-L90)

<!-- gh-comment-id:492614198 --> @evanmiller commented on GitHub (May 15, 2019): Distinct from the Zlib errors there are the ZIP errors, which would help me narrow down the offending code path. https://github.com/jmcnamara/libxlsxwriter/blob/b616fb59ffe0268b1ee0cecf822bf8ed45cf4f30/include/xlsxwriter/third_party/zip.h#L88-L90
gitea-mirror commented 2026-05-05 11:51:03 -06:00
Author
Owner
Copy link

@evanmiller commented on GitHub (May 15, 2019):

I should also add: The library's error messages incorrectly report all ZIP errors as Zlib errors.

<!-- gh-comment-id:492614930 --> @evanmiller commented on GitHub (May 15, 2019): I should also add: The library's error messages incorrectly report all ZIP errors as Zlib errors.
gitea-mirror commented 2026-05-05 11:51:05 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (May 15, 2019):

I should also add: The library's error messages incorrectly report all ZIP errors as Zlib errors.

Ah yes. Thanks.

<!-- gh-comment-id:492629852 --> @jmcnamara commented on GitHub (May 15, 2019): > I should also add: The library's error messages incorrectly report all ZIP errors as Zlib errors. Ah yes. Thanks.
gitea-mirror commented 2026-05-05 11:51:07 -06:00
Author
Owner
Copy link

@jmcnamara commented on GitHub (Jun 8, 2019):

I've pushed a fix for this to master where the library tries to bubble up the zip (not zlib) errors.

I simulated some of the failure conditions and the warning/error is now:

[ERROR] workbook_close(): Zip ZIP_BADZIPFILE error while creating xlsx file 'chart.xlsx'. 
This may require the use_zip64 option for large files. 
System error = Undefined error: 0

Can you try it out with your real world test case.

<!-- gh-comment-id:500127365 --> @jmcnamara commented on GitHub (Jun 8, 2019): I've pushed a fix for this to master where the library tries to bubble up the zip (not zlib) errors. I simulated some of the failure conditions and the warning/error is now: ``` [ERROR] workbook_close(): Zip ZIP_BADZIPFILE error while creating xlsx file 'chart.xlsx'. This may require the use_zip64 option for large files. System error = Undefined error: 0 ``` Can you try it out with your real world test case.
gitea-mirror commented 2026-05-05 11:51:09 -06:00
Author
Owner
Copy link

@evanmiller commented on GitHub (Jun 8, 2019):

Works perfectly. Thank you.

<!-- gh-comment-id:500129851 --> @evanmiller commented on GitHub (Jun 8, 2019): Works perfectly. Thank you.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
coverity
cmake-improvements
cmake_pkgconfig_fix
ctest
button
tables
autofilter
dtoa
iwyu
openssl
gentoo
gh310
condition_format
rich_string_html
header_footer_images
custom_data_labels
object_position
gh265
constant_mode_comments2
constant_mode_comments
vml
md5
vcpkg
hyperlinks
api_refactor
win_fopen
gh203
rich_strings
chartsheet
in_mem_image
gh192
revert-162-master
data_validation
meson
charts
scan_build
utf8_strlen
tmpfileplus
custom_properties
insert_image
default_row
control_chars
worksheet_protect
dev
red_black
panes
mkstemp
defined_names
optimise
wip
v1.2.4
v1.2.3
v1.2.2
v1.2.1
v1.2.0
v1.1.9
v1.1.8
RELEASE_1.1.7
RELEASE_1.1.6
RELEASE_1.1.5
RELEASE_1.1.4
RELEASE_1.1.3
RELEASE_1.1.2
RELEASE_1.1.1
RELEASE_1.1.0
RELEASE_1.0.9
RELEASE_1.0.8
RELEASE_1.0.7
RELEASE_1.0.6
RELEASE_1.0.5
RELEASE_1.0.4
RELEASE_1.0.3
RELEASE_1.0.2
RELEASE_1.0.1
RELEASE_1.0.0
RELEASE_0.9.9
RELEASE_0.9.8
RELEASE_0.9.7
RELEASE_0.9.6
RELEASE_0.9.5
RELEASE_0.9.4
RELEASE_0.9.3
RELEASE_0.9.2
RELEASE_0.9.1
RELEASE_0.9.0
RELEASE_0.8.9
RELEASE_0.8.8
RELEASE_0.8.7
RELEASE_0.8.6
RELEASE_0.8.5
RELEASE_0.8.4
RELEASE_0.8.3
RELEASE_0.8.2
RELEASE_0.8.1
RELEASE_0.8.0
RELEASE_0.7.9
RELEASE_0.7.8
RELEASE_0.7.7
RELEASE_0.7.6
RELEASE_0.7.5
RELEASE_0.7.4
RELEASE_0.7.3
RELEASE_0.7.2
RELEASE_0.7.1
RELEASE_0.7.0
RELEASE_0.6.9
RELEASE_0.6.8
RELEASE_0.6.7
RELEASE_0.6.6
RELEASE_0.6.5
RELEASE_0.6.4
RELEASE_0.6.3
RELEASE_0.6.2
RELEASE_0.6.1
RELEASE_0.6.0
RELEASE_0.5.9
RELEASE_0.5.8
RELEASE_0.5.7
RELEASE_0.5.6
RELEASE_0.5.5
RELEASE_0.5.4
RELEASE_0.5.3
RELEASE_0.5.2
RELEASE_0.5.1
RELEASE_0.5.0
RELEASE_0.4.9
RELEASE_0.4.8
RELEASE_0.4.7
RELEASE_0.4.6
RELEASE_0.4.5
RELEASE_0.4.4
RELEASE_0.4.3
RELEASE_0.4.2
RELEASE_0.4.1
RELEASE_0.4.0
RELEASE_0.3.9
RELEASE_0.3.8
RELEASE_0.3.7
RELEASE_0.3.6
RELEASE_0.3.5
RELEASE_0.3.4
RELEASE_0.3.3
RELEASE_0.3.2
RELEASE_0.3.1
RELEASE_0.3.0
RELEASE_0.2.9
RELEASE_0.2.8
RELEASE_0.2.7
RELEASE_0.2.6
RELEASE_0.2.5
RELEASE_0.2.4
RELEASE_0.2.3
RELEASE_0.2.2
RELEASE_0.2.1
RELEASE_0.2.0
RELEASE_0.1.9
RELEASE_0.1.8
RELEASE_0.1.7
RELEASE_0.1.6
RELEASE_0.1.5
RELEASE_0.1.4
RELEASE_0.1.3
RELEASE_0.1.2
RELEASE_0.1.1
RELEASE_0.1.0
RELEASE_0.0.9
RELEASE_0.0.8
RELEASE_0.0.7
RELEASE_0.0.6
RELEASE_0.0.5
RELEASE_0.0.4
RELEASE_0.0.3
RELEASE_0.0.2
RELEASE_0.0.1
Labels
Clear labels   
awaiting user feedback

   
bug

   
cmake

   
cmake

   
docs

   
feature request

   
in progress

   
long term

   
medium term

   
medium term

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question

   
ready to close

   
short term

   
under investigation

   
wontfix
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/libxlsxwriter#183
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?