[GH-ISSUE #216] Use DESTDIR and PREFIX instead of INSTALL_NAME #174

New issue

Closed

opened 2026-05-05 11:50:04 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:50:04 -06:00

Owner

Originally created by @sjmulder on GitHub (Feb 11, 2019).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/216

Quoting myself in #210

I'd say replace INSTALL_DIR with the more common DESTDIR and PREFIX, e.g.:
DESTDIR ?=
PREFIX  ?= /usr/local

install: [...]
    install -d $(DESTDIR)$(PREFIX)/lib
    install -d $(DESTDIR)$(PREFIX)/include
    install -m 755 lib/*     $(DESTDIR)$(PREFIX)/lib/
    install -m 644 include/* $(DESTDIR)$(PREFIX)/include/
PREFIX is the final location on the user's system. DESTDIR could be staging directory for a package build, a chroot, etc. The distinction is important because you don't want DESTDIR to end up in paths compiled into the program, e.g. the location of a helpfile or library.

And @jmcnamara:

Yes, that is fine with me. [...] Note, the patch will also need to change the docs when they refer to INSTALL_DIR

Originally created by @sjmulder on GitHub (Feb 11, 2019). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/216 Quoting myself in #210 > I'd say replace `INSTALL_DIR` with the more common `DESTDIR` and `PREFIX`, e.g.: > > DESTDIR ?= > PREFIX ?= /usr/local > > install: [...] > install -d $(DESTDIR)$(PREFIX)/lib > install -d $(DESTDIR)$(PREFIX)/include > install -m 755 lib/* $(DESTDIR)$(PREFIX)/lib/ > install -m 644 include/* $(DESTDIR)$(PREFIX)/include/ > > `PREFIX` is the final location on the user's system. `DESTDIR` could be staging directory for a package build, a chroot, etc. The distinction is important because you don't want `DESTDIR` to end up in paths compiled into the program, e.g. the location of a helpfile or library. And @jmcnamara: > Yes, that is fine with me. [...] Note, the patch will also need to change the docs when they refer to `INSTALL_DIR`