[PR #351] [CLOSED] Distinguish numeric keypad keys #351

New issue

Closed

opened 2026-10-02 23:09:25 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-10-02 23:09:25 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/keycastr/keycastr/pull/351
Author: @AbdelrahmanHafez
Created: 8/10/2026
Status: ❌ Closed

Base: main ← Head: feat/numpad-key-labels

📝 Commits (2)

6001d49 test(events): cover numeric keypad labels
f7330ff feat(events): distinguish numeric keypad keys

📊 Changes

2 files changed (+80 additions, -2 deletions)

View changed files

📝 keycastr/KCEventTransformer.m (+19 -2)
📝 keycastr/KCVisualizerTests/KCKeystrokeConversionTests.m (+61 -0)

📄 Description

I know @akitchen already mentioned that they're not accepting PRs for this, but I needed to record a video yesterday with this feature, so I built it anyway. This PR serves as a potential reference that can be adapted to the new version, I'll close it immediately after opening.

Fixes #224 re #296

KeyCastr currently renders numeric keypad keys the same way as their main keyboard equivalents, which makes it impossible to tell which key was pressed in demos.

This prefixes every keypad key with ⊞, including digits, operators, decimal, Clear, Enter, equals, and the JIS keypad comma. Main keyboard keys keep their existing labels.

I added coverage for the complete keypad mapping and the matching main keyboard keys.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/keycastr/keycastr/pull/351 **Author:** [@AbdelrahmanHafez](https://github.com/AbdelrahmanHafez) **Created:** 8/10/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/numpad-key-labels` --- ### 📝 Commits (2) - [`6001d49`](https://github.com/keycastr/keycastr/commit/6001d4993f116eb7a1cd1847d954343e8cf745b6) test(events): cover numeric keypad labels - [`f7330ff`](https://github.com/keycastr/keycastr/commit/f7330ff0e12d9788f49d53ce64e93db8ac603521) feat(events): distinguish numeric keypad keys ### 📊 Changes **2 files changed** (+80 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `keycastr/KCEventTransformer.m` (+19 -2) 📝 `keycastr/KCVisualizerTests/KCKeystrokeConversionTests.m` (+61 -0) </details> ### 📄 Description I know @akitchen already mentioned that they're not accepting PRs for this, but I needed to record a video yesterday with this feature, so I built it anyway. This PR serves as a potential reference that can be adapted to the new version, I'll close it immediately after opening. ----- Fixes #224 re #296 KeyCastr currently renders numeric keypad keys the same way as their main keyboard equivalents, which makes it impossible to tell which key was pressed in demos. This prefixes every keypad key with `⊞`, including digits, operators, decimal, Clear, Enter, equals, and the JIS keypad comma. Main keyboard keys keep their existing labels. I added coverage for the complete keypad mapping and the matching main keyboard keys. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-10-02 23:09:25 -06:00