[PR #1047] [CLOSED] Frpc fixup sub command status and reload ini parse problem #4305

New issue

Closed

opened 2026-05-05 14:39:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:39:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/1047
Author: @ttys3
Created: 1/16/2019
Status: ❌ Closed

Base: dev ← Head: frpc-fixup-sub-command-status-and-reload-ini-parse-problem

📝 Commits (2)

5bdf530 Merge pull request #1045 from fatedier/dev
d076fdb frpc: fixup ini config parse problem in sub command status and reload.

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 cmd/frpc/sub/reload.go (+8 -1)
📝 cmd/frpc/sub/status.go (+8 -1)

📄 Description

frpc: fixup ini config parse problem in sub command status and reload

problem:
when run frpc -c /path-to/frpc.ini status or frpc -c /path-to/frpc.ini reload,
we'll get the error result:

parse ini conf file error: invalid INI syntax on line 1: /path-to/frpc.ini

since func parseClientCommonCfg(fileType int, content string) (err error)
only accept file content, not a filename.

we should call config.GetRenderedConfFromFile first to avoid the problem.
just like the code in cmd/frpc/sub/root.go:

	content, err = config.GetRenderedConfFromFile(cfgFilePath)
	if err != nil {
		return
	}
	g.GlbClientCfg.CfgFile = cfgFilePath

	err = parseClientCommonCfg(CfgFileTypeIni, content)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/1047 **Author:** [@ttys3](https://github.com/ttys3) **Created:** 1/16/2019 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `frpc-fixup-sub-command-status-and-reload-ini-parse-problem` --- ### 📝 Commits (2) - [`5bdf530`](https://github.com/fatedier/frp/commit/5bdf530b7e4e078890814a8e75d94852f8ca21c3) Merge pull request #1045 from fatedier/dev - [`d076fdb`](https://github.com/fatedier/frp/commit/d076fdba76787ebf4c8e08547804e50f2ee746ec) frpc: fixup ini config parse problem in sub command `status` and `reload`. ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/frpc/sub/reload.go` (+8 -1) 📝 `cmd/frpc/sub/status.go` (+8 -1) </details> ### 📄 Description frpc: fixup ini config parse problem in sub command `status` and `reload` problem: when run `frpc -c /path-to/frpc.ini status` or `frpc -c /path-to/frpc.ini reload`, we'll get the error result: > parse ini conf file error: invalid INI syntax on line 1: /path-to/frpc.ini since `func parseClientCommonCfg(fileType int, content string) (err error)` only accept **file content**, not a **filename**. we should call `config.GetRenderedConfFromFile` first to avoid the problem. just like the code in cmd/frpc/sub/root.go: ```go content, err = config.GetRenderedConfFromFile(cfgFilePath) if err != nil { return } g.GlbClientCfg.CfgFile = cfgFilePath err = parseClientCommonCfg(CfgFileTypeIni, content) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>