github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-24 14:12:27 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions
firejail/.github/pull_request_template.md
Kelvin M. Klann be5e5f5cdd pull_request_template.md: restore indentation 
This partially reverts commit 375468008 ("docs: remove indents on
top-level lists and tables", 2023-02-01) from PR #5674.

Commands used to undo the changes:

    $ f=.github/pull_request_template.md; \
      git show 3754680087~1:"$f" >"$f"

I had assumed that a blank line after a list item would end the list
(and so I was confused by the amount of indentation used), but that is
apparently not the case.  See the file rendered before/after the
commit[1] [2].

Relates to #2784.

Reported by @rusty-snake[3].

[1] f5d8d8cc7a/.github/pull_request_template.md
[2] 3754680087/.github/pull_request_template.md
[3] https://github.com/netblue30/firejail/pull/5674#discussion_r1117892922
2023-02-25 15:16:01 -03:00

1.1 KiB
Raw Blame History

If your PR isn't about profiles or you have no idea how to do one of these, skip the following and go ahead with this PR.

If you submit a PR for new profiles or changing profiles, please do the following:

  • The ordering of options follow the rules described in /usr/share/doc/firejail/profile.template.

    Hint: The profile-template is very new. If you install firejail with your package manager, it may be missing. In order to follow the latest rules, it is recommended to use the template from the repository.

  • Order the arguments of options alphabetically. You can easily do this with sort.py. The path to it depends on your distro:

    Distro Path
    Arch/Fedora /usr/lib64/firejail/sort.py
    Debian/Ubuntu/Mint /usr/lib/x86_64-linux-gnu/firejail/sort.py
    local git clone contrib/sort.py

    Note also that the sort.py script exists only since firejail 0.9.61.

See also CONTRIBUTING.md.