[PR #6126] [MERGED] build: mkrpm.sh: append instead of override configure args #5839

New issue

Closed

opened 2026-05-05 10:45:53 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:45:53 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6126
Author: @kmk3
Created: 12/13/2023
Status: ✅ Merged
Merged: 12/21/2023
Merged by: @netblue30

Base: master ← Head: build-mkrpm-append-args

📝 Commits (1)

8fd9ab0 build: mkrpm.sh: append instead of override configure args

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 platform/rpm/mkrpm.sh (+1 -5)

📄 Description

For consistency with mkdeb.sh.

Note: The default arguments and support for argument overriding was
added to to mkrpm.sh on commit 3d97332fd ("Add configure options when
building rpm (#3422)", 2020-05-19).

The support for appending arguments was added to mkdeb.sh on commit
9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to ./configure",
2022-05-13) / PR #5154.

Cc: @rusty-snake @sfc-gh-hyu (from #3422)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6126 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 12/13/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `build-mkrpm-append-args` --- ### 📝 Commits (1) - [`8fd9ab0`](https://github.com/netblue30/firejail/commit/8fd9ab03d662a0bdca7cf2435a25fbc82f36adb0) build: mkrpm.sh: append instead of override configure args ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `platform/rpm/mkrpm.sh` (+1 -5) </details> ### 📄 Description For consistency with mkdeb.sh. Note: The default arguments and support for argument overriding was added to to mkrpm.sh on commit 3d97332fd ("Add configure options when building rpm (#3422)", 2020-05-19). The support for appending arguments was added to mkdeb.sh on commit 9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to ./configure", 2022-05-13) / PR #5154. Cc: @rusty-snake @sfc-gh-hyu (from #3422) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:45:53 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5839

No description provided.

Rows
Columns