[PR #5028] [MERGED] gcov: fix gcov functions always declared as dummy #5335

New issue

Closed

opened 2026-05-05 10:36:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:36:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/5028
Author: @kmk3
Created: 3/9/2022
Status: ✅ Merged
Merged: 3/11/2022
Merged by: @netblue30

Base: master ← Head: fix-gcov-macro

📝 Commits (1)

a265fb0 gcov: fix gcov functions always declared as dummy

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/include/gcov_wrapper.h (+2 -2)

📄 Description

Currently, the check to enable gcov relies on a non-existent macro due
to a typo, which looks like it would cause the dummy/empty versions of
the gcov functions to always be declared (even with --enable-gcov),
instead of the real ones from gcov.h. This commit fixes the typo
(HAS_GCOV -> HAVE_GCOV). See configure.ac for the macro declaration.

This amends commit 5106b2ec4 ("gcov: use no-op functions if not
enabled", 2021-06-20) / PR #4376.

Occurrences of each macro with this commit applied:

$ git grep -F HAVE_GCOV | wc -l
16
$ git grep -F HAS_GCOV | wc -l
0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/5028 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 3/9/2022 **Status:** ✅ Merged **Merged:** 3/11/2022 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-gcov-macro` --- ### 📝 Commits (1) - [`a265fb0`](https://github.com/netblue30/firejail/commit/a265fb0bb6be3d18857ef8dec665e7e2a832f2c9) gcov: fix gcov functions always declared as dummy ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/include/gcov_wrapper.h` (+2 -2) </details> ### 📄 Description Currently, the check to enable gcov relies on a non-existent macro due to a typo, which looks like it would cause the dummy/empty versions of the gcov functions to always be declared (even with --enable-gcov), instead of the real ones from gcov.h. This commit fixes the typo (HAS_GCOV -> HAVE_GCOV). See configure.ac for the macro declaration. This amends commit 5106b2ec4 ("gcov: use no-op functions if not enabled", 2021-06-20) / PR #4376. Occurrences of each macro with this commit applied: $ git grep -F HAVE_GCOV | wc -l 16 $ git grep -F HAS_GCOV | wc -l 0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:36:32 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5335

No description provided.

Rows
Columns