[PR #4095] [MERGED] make appimage mounts private to sandbox #5028

New issue

Closed

opened 2026-05-05 10:31:00 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:31:00 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/4095
Author: @smitsohu
Created: 3/13/2021
Status: ✅ Merged
Merged: 3/14/2021
Merged by: @netblue30

Base: master ← Head: appimage

📝 Commits (2)

a22c5b0 make appimage mounts private to sandbox
ae1d534 appimage: calculate elf offset from file descriptor

📊 Changes

13 files changed (+67 additions, -126 deletions)

View changed files

📝 src/firejail/appimage.c (+42 -87)
📝 src/firejail/appimage_size.c (+8 -14)
📝 src/firejail/cmdline.c (+4 -12)
📝 src/firejail/firejail.h (+3 -3)
📝 src/firejail/fs.c (+0 -2)
📝 src/firejail/main.c (+1 -1)
📝 src/firejail/sandbox.c (+2 -0)
📝 test/appimage/appimage-args.exp (+1 -1)
📝 test/appimage/appimage-trace.exp (+2 -2)
📝 test/appimage/appimage-v1.exp (+1 -1)
📝 test/appimage/appimage-v2.exp (+1 -1)
📝 test/appimage/appimage.sh (+1 -1)
📝 test/appimage/filename.exp (+1 -1)

📄 Description

Mount AppImage on /run/firejail/appimage in the sandbox process, rather than on a subdirectory in the main process. This way the mount is destroyed automatically when the sandbox terminates, and it is private to the sandbox and not a global resource (except for root, who can always peek into the loop device).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/4095 **Author:** [@smitsohu](https://github.com/smitsohu) **Created:** 3/13/2021 **Status:** ✅ Merged **Merged:** 3/14/2021 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `appimage` --- ### 📝 Commits (2) - [`a22c5b0`](https://github.com/netblue30/firejail/commit/a22c5b0a9265be69a46ae1c3b5c9bbba10f3e6e9) make appimage mounts private to sandbox - [`ae1d534`](https://github.com/netblue30/firejail/commit/ae1d534074286bb6c206a13b7b07503ee458396a) appimage: calculate elf offset from file descriptor ### 📊 Changes **13 files changed** (+67 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/appimage.c` (+42 -87) 📝 `src/firejail/appimage_size.c` (+8 -14) 📝 `src/firejail/cmdline.c` (+4 -12) 📝 `src/firejail/firejail.h` (+3 -3) 📝 `src/firejail/fs.c` (+0 -2) 📝 `src/firejail/main.c` (+1 -1) 📝 `src/firejail/sandbox.c` (+2 -0) 📝 `test/appimage/appimage-args.exp` (+1 -1) 📝 `test/appimage/appimage-trace.exp` (+2 -2) 📝 `test/appimage/appimage-v1.exp` (+1 -1) 📝 `test/appimage/appimage-v2.exp` (+1 -1) 📝 `test/appimage/appimage.sh` (+1 -1) 📝 `test/appimage/filename.exp` (+1 -1) </details> ### 📄 Description Mount AppImage on `/run/firejail/appimage` in the sandbox process, rather than on a subdirectory in the main process. This way the mount is destroyed automatically when the sandbox terminates, and it is private to the sandbox and not a global resource (except for root, who can always peek into the loop device). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:31:00 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:36:32 -06:00

[PR #5028] [MERGED] gcov: fix gcov functions always declared as dummy #5335

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#5028

No description provided.

Rows
Columns