[PR #3705] [CLOSED] Improve firejail exec failure logging #4856

New issue

Closed

opened 2026-05-05 10:27:49 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:27:49 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/3705
Author: @sfc-gh-dbrown
Created: 10/27/2020
Status: ❌ Closed

Base: master ← Head: dbrown-SNOW-203610-improve-exec-failure-logging

📝 Commits (4)

88f9317 Add publish rpm script (#2)
0d92a91 Parameterize host url (#3)
01b6095 Bump up sf version to 0.9.62.2
5544ca9 Bump up version to 0.9.62.3

📊 Changes

3 files changed (+67 additions, -0 deletions)

View changed files

➕ snowflake/build_and_publish_rpm.sh (+43 -0)
➕ snowflake/publish_rpm.sh (+22 -0)
➕ snowflake/version.sh (+2 -0)

📄 Description

Firejail already does some basic checks to ensure that the child process looks launch-able, but there is a race between that check and the actual exec. This change writes strerror(errno) to stderr in the case that exec does fail.

This was tested by (temporarily) commenting out the existing checks that verify that the provide child is indeed a valid executable and then trying to launch something that wasn't runable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/3705 **Author:** [@sfc-gh-dbrown](https://github.com/sfc-gh-dbrown) **Created:** 10/27/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dbrown-SNOW-203610-improve-exec-failure-logging` --- ### 📝 Commits (4) - [`88f9317`](https://github.com/netblue30/firejail/commit/88f9317c406a93f8607e9964fd3d6911e5eaad34) Add publish rpm script (#2) - [`0d92a91`](https://github.com/netblue30/firejail/commit/0d92a916c021a5571f90267443202f0e4fb67a29) Parameterize host url (#3) - [`01b6095`](https://github.com/netblue30/firejail/commit/01b609552e07a5a7d9a6fd92753e952894615ddc) Bump up sf version to 0.9.62.2 - [`5544ca9`](https://github.com/netblue30/firejail/commit/5544ca94a99711538c1bbe598ee0a978ef06d3d2) Bump up version to 0.9.62.3 ### 📊 Changes **3 files changed** (+67 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `snowflake/build_and_publish_rpm.sh` (+43 -0) ➕ `snowflake/publish_rpm.sh` (+22 -0) ➕ `snowflake/version.sh` (+2 -0) </details> ### 📄 Description Firejail already does some basic checks to ensure that the child process looks launch-able, but there is a race between that check and the actual exec. This change writes strerror(errno) to stderr in the case that exec does fail. This was tested by (temporarily) commenting out the existing checks that verify that the provide child is indeed a valid executable and then trying to launch something that wasn't runable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:27:49 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:35:22 -06:00

[PR #4856] [MERGED] keep-fd option (#4845) #5271

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#4856

No description provided.

Rows
Columns