[PR #661] [MERGED] Fix command line quoting on joining, move quoting code to functions #3705

New issue

Closed

opened 2026-05-05 10:06:23 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:06:23 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/661
Author: @manevich
Created: 7/30/2016
Status: ✅ Merged
Merged: 7/31/2016
Merged by: @netblue30

Base: master ← Head: join-quoting

📝 Commits (2)

51b6070 fix cmdline quoting on --join + move cmdline quoting code to functions
0545762 exit with error if length of quoted command line is longer than ARG_MAX

📊 Changes

3 files changed (+154 additions, -125 deletions)

View changed files

➕ src/firejail/cmdline.c (+151 -0)
📝 src/firejail/join.c (+2 -22)
📝 src/firejail/main.c (+1 -103)

📄 Description

Fix command line quoting on joining.
Quoting code is moved to functions in separate file to avoid code duplication.
Exit with error if length of quoted command line is longer than ARG_MAX.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/661 **Author:** [@manevich](https://github.com/manevich) **Created:** 7/30/2016 **Status:** ✅ Merged **Merged:** 7/31/2016 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `join-quoting` --- ### 📝 Commits (2) - [`51b6070`](https://github.com/netblue30/firejail/commit/51b6070aec91b3ac294131fdf2e0663eb4992a42) fix cmdline quoting on --join + move cmdline quoting code to functions - [`0545762`](https://github.com/netblue30/firejail/commit/0545762da33ad670681f7c2570eadcd831d14278) exit with error if length of quoted command line is longer than ARG_MAX ### 📊 Changes **3 files changed** (+154 additions, -125 deletions) <details> <summary>View changed files</summary> ➕ `src/firejail/cmdline.c` (+151 -0) 📝 `src/firejail/join.c` (+2 -22) 📝 `src/firejail/main.c` (+1 -103) </details> ### 📄 Description Fix command line quoting on joining. Quoting code is moved to functions in separate file to avoid code duplication. Exit with error if length of quoted command line is longer than `ARG_MAX`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:06:23 -06:00

closed this issue
added the
pull-request
label

gitea-mirror referenced this issue

2026-05-05 10:27:49 -06:00

[PR #3705] [CLOSED] Improve firejail exec failure logging #4856

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#3705

No description provided.

Rows
Columns