[GH-ISSUE #5210] ci: Error: shell=none configured, but no program specified #2919

Closed
opened 2026-05-05 09:34:57 -06:00 by gitea-mirror · 4 comments
Owner

Originally created by @kmk3 on GitHub (Jun 21, 2022).
Original GitHub issue: https://github.com/netblue30/firejail/issues/5210

It was first broken by commit 4d79566ae ("shell none set as default",
2022-06-19).

From its pipeline at https://github.com/netblue30/firejail/runs/6956624903?check_suite_focus=true:

TESTING: profile conditional (test/profiles/conditional.exp)
spawn /bin/bash
firejail --debug --nodbus --profile=cond1.profile
runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ 
<$ firejail --debug --nodbus --profile=cond1.profile       
Reading profile cond1.profile
conditional HAS_NODBUS, private
Error: shell=none configured, but no program specified
runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ TESTING ERROR 1
[...]
TESTING: ignore command (test/profiles/ignore.exp)
spawn /bin/bash
firejail --profile=ignore.profile --ignore=seccomp 
runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ 
<firejail --profile=ignore.profile --ignore=seccomp        
Reading profile ignore.profile
Warning: "shell none" command in the profile file is done by default; the command will be deprecated
Error: please use --profile after --ignore
firejail --debug --ignore=seccomp
runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ 
<il/test/profiles$ firejail --debug --ignore=seccomp       
Error: shell=none configured, but no program specified
runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ TESTING ERROR 1
[...]
make[1]: *** [Makefile:6: profiles] Error 1
make[1]: Leaving directory '/home/runner/work/firejail/firejail/test'
make: *** [Makefile:260: test-profiles] Error 2
##[error]Process completed with exit code 2.

Then the error changed a few times and now it is the same since commit
bb14c205b ("shell none set as default (6)", 2022-06-19).

From its pipeline at https://github.com/netblue30/firejail/runs/6958592591?check_suite_focus=true:

TESTING: doubledash (test/environment/doubledash.exp
spawn /bin/bash
firejail -- ls -- -testdir
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ 
<rejail/test/environment$ firejail -- ls -- -testdir           
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 10196, child pid 10197
Warning: cleaning all supplementary groups
]0;firejail ls -- -testdir Child process initialized in 80.71 ms
bash  ttt

Parent is shutting down, bye...
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ 
<vironment$ firejail --name=testing -- -testdir/bash           
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 10201, child pid 10202
Warning: cleaning all supplementary groups
]0;firejail -testdir/bash Child process initialized in 78.53 ms
spawn /bin/bash
firejail --join=testing -- -testdir/bash
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ 
<vironment$ firejail --join=testing -- -testdir/bash           
Switching to pid 10202, the first child process inside the sandbox
spawn /bin/bash
firejail --list;ls -d /tmp
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ 
<rejail/test/environment$ firejail --list;ls -d /tmp           
10201:runner:testing:firejail --name=testing -- -testdir/bash 
/tmp
firejail --list;ls -d /tmp
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ 
<rejail/test/environment$ firejail --list;ls -d /tmp           
10201:runner:testing:firejail --name=testing -- -testdir/bash 
/tmp
runner@fv-az241-472:~/work/firejail/firejail/test/environment$ TESTING ERROR 8 (join)
[...]
make[1]: *** [Makefile:6: environment] Error 1
make: *** [Makefile:260: test-environment] Error 2
make[1]: Leaving directory '/home/runner/work/firejail/firejail/test'
##[error]Process completed with exit code 2.

Relates to #5190 #5196.

Cc: @netblue30 @reinerh

Originally created by @kmk3 on GitHub (Jun 21, 2022). Original GitHub issue: https://github.com/netblue30/firejail/issues/5210 It was first broken by commit 4d79566ae ("shell none set as default", 2022-06-19). From its pipeline at <https://github.com/netblue30/firejail/runs/6956624903?check_suite_focus=true>: ``` TESTING: profile conditional (test/profiles/conditional.exp) spawn /bin/bash firejail --debug --nodbus --profile=cond1.profile runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ <$ firejail --debug --nodbus --profile=cond1.profile  Reading profile cond1.profile conditional HAS_NODBUS, private Error: shell=none configured, but no program specified runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ TESTING ERROR 1 [...] TESTING: ignore command (test/profiles/ignore.exp) spawn /bin/bash firejail --profile=ignore.profile --ignore=seccomp runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ <firejail --profile=ignore.profile --ignore=seccomp  Reading profile ignore.profile Warning: "shell none" command in the profile file is done by default; the command will be deprecated Error: please use --profile after --ignore firejail --debug --ignore=seccomp runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ <il/test/profiles$ firejail --debug --ignore=seccomp  Error: shell=none configured, but no program specified runner@fv-az36-448:~/work/firejail/firejail/test/profiles$ TESTING ERROR 1 [...] make[1]: *** [Makefile:6: profiles] Error 1 make[1]: Leaving directory '/home/runner/work/firejail/firejail/test' make: *** [Makefile:260: test-profiles] Error 2 ##[error]Process completed with exit code 2. ``` Then the error changed a few times and now it is the same since commit bb14c205b ("shell none set as default (6)", 2022-06-19). From its pipeline at <https://github.com/netblue30/firejail/runs/6958592591?check_suite_focus=true>: ``` TESTING: doubledash (test/environment/doubledash.exp spawn /bin/bash firejail -- ls -- -testdir runner@fv-az241-472:~/work/firejail/firejail/test/environment$ <rejail/test/environment$ firejail -- ls -- -testdir  Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc ** Note: you can use --noprofile to disable default.profile ** Parent pid 10196, child pid 10197 Warning: cleaning all supplementary groups ]0;firejail ls -- -testdir Child process initialized in 80.71 ms bash ttt Parent is shutting down, bye... runner@fv-az241-472:~/work/firejail/firejail/test/environment$ <vironment$ firejail --name=testing -- -testdir/bash  Reading profile /etc/firejail/default.profile Reading profile /etc/firejail/disable-common.inc Reading profile /etc/firejail/disable-programs.inc ** Note: you can use --noprofile to disable default.profile ** Parent pid 10201, child pid 10202 Warning: cleaning all supplementary groups ]0;firejail -testdir/bash Child process initialized in 78.53 ms spawn /bin/bash firejail --join=testing -- -testdir/bash runner@fv-az241-472:~/work/firejail/firejail/test/environment$ <vironment$ firejail --join=testing -- -testdir/bash  Switching to pid 10202, the first child process inside the sandbox spawn /bin/bash firejail --list;ls -d /tmp runner@fv-az241-472:~/work/firejail/firejail/test/environment$ <rejail/test/environment$ firejail --list;ls -d /tmp  10201:runner:testing:firejail --name=testing -- -testdir/bash /tmp firejail --list;ls -d /tmp runner@fv-az241-472:~/work/firejail/firejail/test/environment$ <rejail/test/environment$ firejail --list;ls -d /tmp  10201:runner:testing:firejail --name=testing -- -testdir/bash /tmp runner@fv-az241-472:~/work/firejail/firejail/test/environment$ TESTING ERROR 8 (join) [...] make[1]: *** [Makefile:6: environment] Error 1 make: *** [Makefile:260: test-environment] Error 2 make[1]: Leaving directory '/home/runner/work/firejail/firejail/test' ##[error]Process completed with exit code 2. ``` Relates to #5190 #5196. Cc: @netblue30 @reinerh
Author
Owner

@netblue30 commented on GitHub (Jun 21, 2022):

I hope to have all cleaned up by the weekend.

<!-- gh-comment-id:1161635246 --> @netblue30 commented on GitHub (Jun 21, 2022): I hope to have all cleaned up by the weekend.
Author
Owner

@kmk3 commented on GitHub (Jun 21, 2022):

Fixed by commit 7ad735dea ("deprecating --shell (3) (#5196)", 2022-06-21).

<!-- gh-comment-id:1162340299 --> @kmk3 commented on GitHub (Jun 21, 2022): Fixed by commit 7ad735dea ("deprecating --shell (3) (#5196)", 2022-06-21).
Author
Owner

@kmk3 commented on GitHub (Jun 21, 2022):

@netblue30 commented on Jun 21:

I hope to have all cleaned up by the weekend.

Now that CI is finally working again, would you mind doing the rest of the
changes in a separate branch? Example:

# update master
git checkout master
git pull
# create a new branch from master
git branch shell-none-default

# (loop this section until done)
git checkout shell-none-default
# (make some commits)
# push changes to GitHub (might need "-u" argument on first push)
git push

# (open a pull request on GitHub: master <- shell-none-default)

That way the changes do not impact anyone until they're in a finished state and
so everyone can get proper CI checks on their PRs in the meantime. Also, this
would allow people to review the changes and catch any issues before they reach
master.

Note: The pull request can also be opened as a draft as soon as the branch is
created/pushed, which would allow reviewing the commits as they are being
made/pushed. This is a bit more similar to the current workflow, except that
master is not affected.

<!-- gh-comment-id:1162363360 --> @kmk3 commented on GitHub (Jun 21, 2022): @netblue30 commented [on Jun 21](https://github.com/netblue30/firejail/issues/5210#issuecomment-1161635246): > I hope to have all cleaned up by the weekend. Now that CI is finally working again, would you mind doing the rest of the changes in a separate branch? Example: ```sh # update master git checkout master git pull # create a new branch from master git branch shell-none-default # (loop this section until done) git checkout shell-none-default # (make some commits) # push changes to GitHub (might need "-u" argument on first push) git push # (open a pull request on GitHub: master <- shell-none-default) ``` That way the changes do not impact anyone until they're in a finished state and so everyone can get proper CI checks on their PRs in the meantime. Also, this would allow people to review the changes and catch any issues before they reach master. Note: The pull request can also be opened as a draft as soon as the branch is created/pushed, which would allow reviewing the commits as they are being made/pushed. This is a bit more similar to the current workflow, except that master is not affected.
Author
Owner

@netblue30 commented on GitHub (Jun 23, 2022):

will do!

<!-- gh-comment-id:1164558944 --> @netblue30 commented on GitHub (Jun 23, 2022): will do!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#2919
No description provided.