mirror of
https://github.com/netblue30/firejail.git
synced 2026-05-15 14:16:14 -06:00
[GH-ISSUE #2787] x11 xorg doesn't seem to respect the quiet option #1746
Labels
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/firejail#1746
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jun 20, 2019).
Original GitHub issue: https://github.com/netblue30/firejail/issues/2787
Recently I started to experiment/test profiles with
--auditand trying to fix anything reported asUGLYorMAYBEin .local files. This has proven to work really well. One thing I've noticed though is thatx11 xorgdoesn't seem to follow thequietoption. E.g. with dig (which has the quiet option in its profile):Explicitly calling the quiet option on a profile that doesn't have it (e.g. claws-mail) also shows the same behavior:
Is this intended (with audit)?
@chiraag-nataraj commented on GitHub (Jun 22, 2019):
Seems like those statements aren't inside a
if(arg_debug), so it seems like the intention is for them to always be printed? I suppose that's up for debate though heh.@ghost commented on GitHub (Jun 22, 2019):
@chiraag-nataraj That indeed seems the intention, which I find counterintuitive in the case of
quiet. I'll experiment with(arg_debug),(arg_quiet)etcetera in the code and try not to break anything.@netblue30 commented on GitHub (Jun 24, 2019):
It shouldn't show anything on the screen, we have to clean it up. @glitsj16 give it a try.
@ghost commented on GitHub (Jun 24, 2019):
@netblue30 Thanks for clearing that up. I'm in the middle of an annual dance, relocating the family now school responsibilities are suspended for a couple of months. In a day or two I should have a PR ready.
@netblue30 commented on GitHub (Jun 25, 2019):
No problem, take your time.
@ghost commented on GitHub (Jun 26, 2019):
@netblue30 I left in the xauth output while using --debug (where it might be helpful). If this is not what you want, I can easily take out the relevant conditional in https://github.com/netblue30/firejail/blob/master/src/firejail/x11.c#L1135 and below. Hope this didn't break anything...