github-starred/firejail
2
0
Fork 0
mirror of https://github.com/netblue30/firejail.git synced 2026-05-15 14:16:14 -06:00
Code Issues 531 Projects Packages Wiki Activity Actions 6

[GH-ISSUE #1746] Building rpm - what's going wrong? #1183

New issue
Closed
opened 2026-05-05 07:37:07 -06:00 by gitea-mirror · 11 comments
gitea-mirror commented 2026-05-05 07:37:07 -06:00
Owner
Copy link

Originally created by @Fred-Barclay on GitHub (Jan 21, 2018).
Original GitHub issue: https://github.com/netblue30/firejail/issues/1746

I'm trying to figure out why make rpms always fails, and I've hit a bit of a roadblock (granted, my lack of knowlege about rpms isn't contributing to my efforts 😁 ).
Currently building goes something like this:

./platform/rpm/mkrpm.sh firejail 0.9.53
configure: WARNING: unrecognized options: --disable-dependency-tracking
configure: WARNING: unrecognized options: --disable-dependency-tracking
1650 blocks
error: Installed (but unpackaged) file(s) found:
...
mv: cannot stat '/tmp/tmp.8utUom6DKC/SRPMS/*.rpm': No such file or directory
mv: cannot stat '/tmp/tmp.8utUom6DKC/RPMS/*/*rpm': No such file or directory
make: *** [Makefile:230: rpms] Error 1

The /tmp/tmp.SOMEVALUE/SRPMS and RPMS directories are being created, but no rpm is being build in them.

I've traced the errors back to e470524, at which point the faulty builds begin. This commit removed the man page firejail-config from the repo. Generally speaking, building rpms was successful for all earlier commits.

platform/rpm/mkrpm.sh hasn't been edited since before this point, so I believe the problem is not in the rpm portion of the build process. @netblue30 how do you build the .rpms for release on sourceforge?

Full output of build for current state is https://gitlab.com/snippets/1694579
Full output of build for the commit for which the build began failing is https://gitlab.com/snippets/1694580
Full output of the last commit with a good build is https://gitlab.com/snippets/1694581

See also #1583

Cheers!
Fred

Originally created by @Fred-Barclay on GitHub (Jan 21, 2018). Original GitHub issue: https://github.com/netblue30/firejail/issues/1746 I'm trying to figure out why `make rpms` always fails, and I've hit a bit of a roadblock (granted, my lack of knowlege about rpms isn't contributing to my efforts 😁 ). Currently building goes something like this: ```$ make rpms ./platform/rpm/mkrpm.sh firejail 0.9.53 configure: WARNING: unrecognized options: --disable-dependency-tracking configure: WARNING: unrecognized options: --disable-dependency-tracking 1650 blocks error: Installed (but unpackaged) file(s) found: ... mv: cannot stat '/tmp/tmp.8utUom6DKC/SRPMS/*.rpm': No such file or directory mv: cannot stat '/tmp/tmp.8utUom6DKC/RPMS/*/*rpm': No such file or directory make: *** [Makefile:230: rpms] Error 1 ``` The /tmp/tmp.SOMEVALUE/SRPMS and RPMS directories are being created, but no rpm is being build in them. I've traced the errors back to e470524, at which point the faulty builds begin. This commit removed the man page `firejail-config` from the repo. Generally speaking, building rpms was successful for all earlier commits. platform/rpm/mkrpm.sh hasn't been edited since before this point, so I believe the problem is not in the rpm portion of the build process. @netblue30 how do you build the .rpms for release on sourceforge? Full output of build for current state is https://gitlab.com/snippets/1694579 Full output of build for the commit for which the build began failing is https://gitlab.com/snippets/1694580 Full output of the last commit with a good build is https://gitlab.com/snippets/1694581 See also #1583 Cheers! Fred
gitea-mirror 2026-05-05 07:37:07 -06:00
gitea-mirror commented 2026-05-05 07:37:14 -06:00
Author
Owner
Copy link

@netblue30 commented on GitHub (Jan 23, 2018):

To answer a question from an older thread, I build the official rpm packages on a CentOS 7. First I remove /etc/firejail directory (sudo rm -fr /etc/firejail), I install firejail (sudo make install-strip), then I create the rpm by running platform/rpm/old-mkrpm.sh script. The package is placed by the script in user home directory.

I couldn't get platform/rpm/mkrpm.sh running. It works on some Fedora versions, for me on CentOS it doesn't. The regular ./configure && make && sudo make install works fine on CentOS 6 and 7 and any Fedora.

<!-- gh-comment-id:359808122 --> @netblue30 commented on GitHub (Jan 23, 2018): To answer a question from an older thread, I build the official rpm packages on a CentOS 7. First I remove /etc/firejail directory (sudo rm -fr /etc/firejail), I install firejail (sudo make install-strip), then I create the rpm by running platform/rpm/old-mkrpm.sh script. The package is placed by the script in user home directory. I couldn't get platform/rpm/mkrpm.sh running. It works on some Fedora versions, for me on CentOS it doesn't. The regular ./configure && make && sudo make install works fine on CentOS 6 and 7 and any Fedora.
gitea-mirror commented 2026-05-05 07:37:15 -06:00
Author
Owner
Copy link

@reinerh commented on GitHub (Jan 23, 2018):

@Fred-Barclay the firejail-config.5.gz error should have been fixed by b66676c.
I think the other error you are seeing now is another regression that was introduced.

It sounds like it is installing some files (during "make install") that are not added to the packaging, so it aborts the build.
But I'm not an rpm expert, so I'm not really sure...

<!-- gh-comment-id:359881457 --> @reinerh commented on GitHub (Jan 23, 2018): @Fred-Barclay the firejail-config.5.gz error should have been fixed by b66676c. I think the other error you are seeing now is another regression that was introduced. It sounds like it is installing some files (during "make install") that are not added to the packaging, so it aborts the build. But I'm not an rpm expert, so I'm not really sure...
gitea-mirror commented 2026-05-05 07:37:17 -06:00
Author
Owner
Copy link

@reinerh commented on GitHub (Jan 23, 2018):

In the .spec file there is indeed nothing in the %files section that matches those files...

<!-- gh-comment-id:359882084 --> @reinerh commented on GitHub (Jan 23, 2018): In the .spec file there is indeed nothing in the %files section that matches those files...
gitea-mirror commented 2026-05-05 07:37:18 -06:00
Author
Owner
Copy link

@reinerh commented on GitHub (Jan 23, 2018):

@Fred-Barclay Can you please check if 59fb1d9f improves something?

<!-- gh-comment-id:359882662 --> @reinerh commented on GitHub (Jan 23, 2018): @Fred-Barclay Can you please check if 59fb1d9f improves something?
gitea-mirror commented 2026-05-05 07:37:20 -06:00
Author
Owner
Copy link

@SkewedZeppelin commented on GitHub (Jan 23, 2018):

@reinerh here are some results on Fedora 27

$ ./configure && make rpms

./platform/rpm/mkrpm.sh firejail 0.9.53
configure: WARNING: unrecognized options: --disable-dependency-tracking
configure: WARNING: unrecognized options: --disable-dependency-tracking
1650 blocks

^outputs an RPM, not sure what is in it

$ ./configure && make && make rpms

./platform/rpm/mkrpm.sh firejail 0.9.53
configure: WARNING: unrecognized options: --disable-dependency-tracking
configure: WARNING: unrecognized options: --disable-dependency-tracking
error: Empty %files file /tmp/tmp.IZHeAbChE7/BUILD/firejail-0.9.53/debugsourcefiles.list
    Empty %files file /tmp/tmp.IZHeAbChE7/BUILD/firejail-0.9.53/debugsourcefiles.list
mv: cannot stat '/tmp/tmp.IZHeAbChE7/SRPMS/*.rpm': No such file or directory
mv: cannot stat '/tmp/tmp.IZHeAbChE7/RPMS/*/*rpm': No such file or directory
make: *** [Makefile:230: rpms] Error 1

^fails and doesn't create RPM

<!-- gh-comment-id:359893587 --> @SkewedZeppelin commented on GitHub (Jan 23, 2018): @reinerh here are some results on Fedora 27 ``` $ ./configure && make rpms ./platform/rpm/mkrpm.sh firejail 0.9.53 configure: WARNING: unrecognized options: --disable-dependency-tracking configure: WARNING: unrecognized options: --disable-dependency-tracking 1650 blocks ``` ^outputs an RPM, not sure what is in it ``` $ ./configure && make && make rpms ./platform/rpm/mkrpm.sh firejail 0.9.53 configure: WARNING: unrecognized options: --disable-dependency-tracking configure: WARNING: unrecognized options: --disable-dependency-tracking error: Empty %files file /tmp/tmp.IZHeAbChE7/BUILD/firejail-0.9.53/debugsourcefiles.list Empty %files file /tmp/tmp.IZHeAbChE7/BUILD/firejail-0.9.53/debugsourcefiles.list mv: cannot stat '/tmp/tmp.IZHeAbChE7/SRPMS/*.rpm': No such file or directory mv: cannot stat '/tmp/tmp.IZHeAbChE7/RPMS/*/*rpm': No such file or directory make: *** [Makefile:230: rpms] Error 1 ``` ^fails and doesn't create RPM
gitea-mirror commented 2026-05-05 07:37:22 -06:00
Author
Owner
Copy link

@reinerh commented on GitHub (Jan 23, 2018):

@SpotComms thanks for testing. What errors are now still remaining? Can you please post them?

<!-- gh-comment-id:359895251 --> @reinerh commented on GitHub (Jan 23, 2018): @SpotComms thanks for testing. What errors are now still remaining? Can you please post them?
gitea-mirror commented 2026-05-05 07:37:22 -06:00
Author
Owner
Copy link

@Fred-Barclay commented on GitHub (Jan 23, 2018):

@reinerh On Fedora 26 (Korora 26 specifically), ./configure --prefix=/usr && make rpms && sudo yum install firejail-0.9.53-1.x86_64.rpm works perfectly!

<!-- gh-comment-id:359966704 --> @Fred-Barclay commented on GitHub (Jan 23, 2018): @reinerh On Fedora 26 (Korora 26 specifically), `./configure --prefix=/usr && make rpms && sudo yum install firejail-0.9.53-1.x86_64.rpm` works perfectly!
gitea-mirror commented 2026-05-05 07:37:24 -06:00
Author
Owner
Copy link

@SkewedZeppelin commented on GitHub (Jan 23, 2018):

@Fred-Barclay I don't think that RPM is the full thing/proper though. As ./configure && make rpms completes much quicker than make (actually compiling all the programs). I wonder if it is just including the existing /usr/bin/firejail, etc. in it. The profiles in it however do seem update to date.

Edit: I extracted the RPM and hashed some of the files and they are indeed different from the existing install (0.9.52 from Sourceforge/netblue)

<!-- gh-comment-id:359969043 --> @SkewedZeppelin commented on GitHub (Jan 23, 2018): @Fred-Barclay I don't think that RPM is the full thing/proper though. As `./configure && make rpms` completes much quicker than `make` (actually compiling all the programs). I wonder if it is just including the existing /usr/bin/firejail, etc. in it. The profiles in it however do seem update to date. Edit: I extracted the RPM and hashed some of the files and they are indeed different from the existing install (0.9.52 from Sourceforge/netblue)
gitea-mirror commented 2026-05-05 07:37:25 -06:00
Author
Owner
Copy link

@Fred-Barclay commented on GitHub (Jan 23, 2018):

I wonder if it is just including the existing /usr/bin/firejail, etc. in it.

Do you mean from a previous installation of firejail? If so, that's not the case here - it's a brand-new Korora install.

<!-- gh-comment-id:359969415 --> @Fred-Barclay commented on GitHub (Jan 23, 2018): > I wonder if it is just including the existing /usr/bin/firejail, etc. in it. Do you mean from a previous installation of firejail? If so, that's not the case here - it's a brand-new Korora install.
gitea-mirror commented 2026-05-05 07:37:26 -06:00
Author
Owner
Copy link

@SkewedZeppelin commented on GitHub (Jan 23, 2018):

Okay I think it is indeed fixed 🎉 , thanks @reinerh.

@Fred-Barclay make rpms wasn't actually outputting any gcc output, so I wasn't sure if it was actually being compiled. But I just compared and make rpms does take a few seconds longer than make, implying that it is actually compiling everything.

I guess we can close this now.

<!-- gh-comment-id:359970670 --> @SkewedZeppelin commented on GitHub (Jan 23, 2018): Okay I think it is indeed fixed :tada: , thanks @reinerh. @Fred-Barclay make rpms wasn't actually outputting any gcc output, so I wasn't sure if it was actually being compiled. But I just compared and `make rpms` does take a few seconds longer than `make`, implying that it is actually compiling everything. I guess we can close this now.
gitea-mirror commented 2026-05-05 07:37:27 -06:00
Author
Owner
Copy link

@Fred-Barclay commented on GitHub (Jan 23, 2018):

make rpms wasn't actually outputting any gcc output, so I wasn't sure if it was actually being compiled

I believe that's because of the --quiet flag in https://github.com/netblue30/firejail/blob/master/platform/rpm/mkrpm.sh#L39. If you remove it you should see everything compiling.

Thanks @reinerh ! 🎉

<!-- gh-comment-id:359971192 --> @Fred-Barclay commented on GitHub (Jan 23, 2018): > make rpms wasn't actually outputting any gcc output, so I wasn't sure if it was actually being compiled I believe that's because of the `--quiet` flag in https://github.com/netblue30/firejail/blob/master/platform/rpm/mkrpm.sh#L39. If you remove it you should see everything compiling. Thanks @reinerh ! 🎉
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
serialize_remounts_v2
landlock_v4
landlock
release-0.9.64
release-0.9.62
gitlab_ci
LTSbase
fred_ctests
docs
0.9.80
0.9.80-rc1
0.9.78
0.9.76
0.9.76-rc4
0.9.76-rc3
0.9.76-rc2
0.9.76-rc1
0.9.74
landlock-split
0.9.72
0.9.72rc1
0.9.70
0.9.68
0.9.68rc1
0.9.66
0.9.66rc1
0.9.64.4
0.9.64.2
0.9.64
0.9.64rc1
0.9.62.4
0.9.62.2
0.9.62
0.9.56.2-LTS
0.9.60
0.9.60-rc1
0.9.58.2
0.9.58
0.9.58-rc1
0.9.56-LTS-release
0.9.56-LTS
0.9.56
0.9.56-rc1
0.9.54
0.9.54-rc2
0.9.54-rc1
0.9.52
0.9.38.12
0.9.50
0.9.50-rc1
0.9.48
0.9.46
0.9.46-rc1
0.9.44.10
0.9.44.8
0.9.44.6
0.9.38.10
0.9.44.4
0.9.38.8
0.9.44.2
0.9.44
0.9.44-rc1
0.9.38.4
0.9.42
0.9.42-rc2
0.9.38.2
0.9.42-rc1
disable-globalcfg
0.9.40
0.9.40-rc1
0.9.38
0.9.38-rc1
0.9.36
0.9.36-rc1
0.9.34
0.9.34-rc1
0.9.32
0.9.32-rc1
0.9.30
0.9.30-rc1
Labels
Clear labels   
LTS merge

   
LTS merge

   
bug

   
bug

   
converted-to-discussion

   
doc-todo

   
documentation

   
duplicate

   
enhancement

   
file-transfer

   
firecfg

   
firejail-in-firejail

   
firetools

   
graphics

   
help wanted

   
information_old

   
installation

   
invalid

   
modif

   
moved

   
needinfo

   
networking

   
notabug

   
notourbug

   
old-version

   
overlayfs

   
packaging

   
profile-request

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question_old

   
removal

   
runtime-permissions

   
sandbox-ipc

   
security

   
stale

   
wiki

   
wiki

   
wontfix

   
wordpress

   
workaround
No labels
LTS merge
LTS merge
bug
bug
converted-to-discussion
doc-todo
documentation
duplicate
enhancement
file-transfer
firecfg
firejail-in-firejail
firetools
graphics
help wanted
information_old
installation
invalid
modif
moved
needinfo
networking
notabug
notourbug
old-version
overlayfs
packaging
profile-request
pull-request
question
question_old
removal
runtime-permissions
sandbox-ipc
security
stale
wiki
wiki
wontfix
wordpress
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#1183
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?