Debian has a separate "firejail-profiles" package for the profiles
(besides the main "firejail" package), which conflicts with our package
when trying to install it[1]:
$ sudo dpkg -i firejail_0.9.80_1_amd64.deb
FAIL: (Reading database ... 238526 files and directories currently installed.)
Preparing to unpack ./firejail_0.9.80_1_amd64.deb ...
Unpacking firejail (0.9.80-1) over (0.9.74-1~0ubuntu22.04.0) ...
dpkg: error processing archive ./firejail_0.9.80_1_amd64.deb (--install):
trying to overwrite '/etc/firejail/0ad.profile', which is also in package firejail-
profiles 0.9.74-1~0ubuntu22.04.0
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Errors were encountered while processing:
./firejail_0.9.80_1_amd64.deb
So add a `Conflicts:` line for "firejail-profiles".
Relates to #7110.
[1] https://github.com/netblue30/firejail/issues/7072#issuecomment-4273240052
Reported-by: @ginto37
For consistency and to make it clearer where jobs differ (for example,
to see where `--enable-analyzer` is used).
Changes:
* Always use --prefix=/usr and --enable-fatal-warnings (except in the
Alpine job due to current warnings; see #6224)
* Use the same argument order
Note: mkdeb.sh and platform/rpm/mkrpm.sh already pass `--prefix=/usr` to
./configure.
To make the CI logs more informative, as currently nothing from the
build itself is shown.
Added on commit d684d9988 ("Fix mkrpm.sh", 2016-02-16) / PR #297.
For consistency with mkdeb.sh.
Note: The default arguments and support for argument overriding was
added to to mkrpm.sh on commit 3d97332fd ("Add configure options when
building rpm (#3422)", 2020-05-19).
The support for appending arguments was added to mkdeb.sh on commit
9a0fbbd71 ("mkdeb.sh.in: pass remaining arguments to ./configure",
2022-05-13) / PR #5154.
Commands used to list the file extensions used in the project:
$ git ls-files | sed -En 's/.*(\.[^.]+)$/\1/p' |
LC_ALL=C sort | uniq -c
For rules that are more specific to a given directory, put a dedicated
.editorconfig file in it.
Almost all of the shell scripts in the repository use tabs for
indentation (or have no indentation at all):
$ git grep -Il '^\t' -- '*.sh' | wc -l
19
$ git grep -Il '^ ' -- '*.sh' | wc -l
5
$ git grep -IL '^[ \t]' -- '*.sh' | wc -l
25
So do the same in the few shell scripts that currently use spaces for
indentation.
Except for the following file:
* platform/rpm/mkrpm.sh
Not sure if it's following a packaging-specific scheme, so just fix the
one indentation inconsistency in it and otherwise leave it as is for
now.
Command used to search for shell scripts using spaces for indentation:
$ git grep -In '^ ' -- '*.sh'