mirror of
https://github.com/debauchee/barrier.git
synced 2026-05-15 14:16:02 -06:00
[GH-ISSUE #1219] Unquoted service path on windows #981
Labels
No labels
HiDPI
bounty
bsd/freebsd
bsd/openbsd
bug
bug
build-infra
cantfix
critical
doc
duplicate
enhancement
fix-available
from git
from release
good first issue
help wanted
installer/package
invalid
linux
macOS
meta
needs testing
pull-request
query
question
regression
regression
v2.4.0
windows
wontfix
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/barrier#981
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @petecog on GitHub (Jul 1, 2021).
Original GitHub issue: https://github.com/debauchee/barrier/issues/1219
Describe the bug
I've noticed that the service path created in windows registry is unquoted - which can cause a vulnerability. see https://medium.com/@SumitVerma101/windows-privilege-escalation-part-1-unquoted-service-path-c7a011a8d8ae for example
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Ideally value should be quoted e.g. "C:\Program Files\Barrier\barrierd.exe" - becuse of the space in 'Program Files'
Desktop (please complete the following information):
@shymega commented on GitHub (Jul 6, 2021):
Hi. Thanks for the report. Given this is a serious security vulnerability, perhaps it should be reported to an email address to me and the other devs directly - but that's not set up yet. I'll look into that... we have another report as well, so obviously we have some vulns that need looking into. Rest assured, we are looking into this - I'll keep the issue open for now.
Thanks again!
@starmaid commented on GitHub (Mar 11, 2022):
bumping this, still an issue in 2.4.0 and nessus keeps flagging it