[PR #981] [MERGED] Remove some #defines that had no useful effect #1729

New issue

Closed

opened 2026-05-05 08:00:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 08:00:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debauchee/barrier/pull/981
Author: @whot
Created: 12/9/2020
Status: ✅ Merged
Merged: 12/9/2020
Merged by: @p12tic

Base: master ← Head: wip/simplify-ifdefs

📝 Commits (3)

38390f9 Undef X_DISPLAY_MISSING
f3eb891 Move the XTest check to cmake
1474f04 Remove an unreachable preprocessor directive

📊 Changes

11 files changed (+42 additions, -112 deletions)

View changed files

📝 CMakeLists.txt (+2 -3)
📝 res/config.h.in (+0 -9)
📝 src/lib/platform/IXWindowsImpl.h (+25 -33)
📝 src/lib/platform/XWindowsClipboard.h (+1 -5)
📝 src/lib/platform/XWindowsEventQueueBuffer.h (+1 -5)
📝 src/lib/platform/XWindowsKeyState.cpp (+5 -9)
📝 src/lib/platform/XWindowsKeyState.h (+4 -12)
📝 src/lib/platform/XWindowsScreen.h (+1 -5)
📝 src/lib/platform/XWindowsScreenSaver.cpp (+1 -21)
📝 src/lib/platform/XWindowsScreenSaver.h (+1 -5)
📝 src/lib/platform/XWindowsUtil.h (+1 -5)

📄 Description

X_DISPLAY_MISSING was never set by anything and thus could never be true
HAVE_DPMS_PROTOTYPES was always true in the one instance where we checked for it
HAVE_X11_EXTENSIONS_XTEST_H caused a compiler error, moved to a cmake error now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debauchee/barrier/pull/981 **Author:** [@whot](https://github.com/whot) **Created:** 12/9/2020 **Status:** ✅ Merged **Merged:** 12/9/2020 **Merged by:** [@p12tic](https://github.com/p12tic) **Base:** `master` ← **Head:** `wip/simplify-ifdefs` --- ### 📝 Commits (3) - [`38390f9`](https://github.com/debauchee/barrier/commit/38390f9b88cad323254d9d3e405972bc5123b226) Undef X_DISPLAY_MISSING - [`f3eb891`](https://github.com/debauchee/barrier/commit/f3eb89121db00c959daf374c8712f15860276b52) Move the XTest check to cmake - [`1474f04`](https://github.com/debauchee/barrier/commit/1474f04f5360d39aa7b4b3df91fe1157ca2a50fe) Remove an unreachable preprocessor directive ### 📊 Changes **11 files changed** (+42 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -3) 📝 `res/config.h.in` (+0 -9) 📝 `src/lib/platform/IXWindowsImpl.h` (+25 -33) 📝 `src/lib/platform/XWindowsClipboard.h` (+1 -5) 📝 `src/lib/platform/XWindowsEventQueueBuffer.h` (+1 -5) 📝 `src/lib/platform/XWindowsKeyState.cpp` (+5 -9) 📝 `src/lib/platform/XWindowsKeyState.h` (+4 -12) 📝 `src/lib/platform/XWindowsScreen.h` (+1 -5) 📝 `src/lib/platform/XWindowsScreenSaver.cpp` (+1 -21) 📝 `src/lib/platform/XWindowsScreenSaver.h` (+1 -5) 📝 `src/lib/platform/XWindowsUtil.h` (+1 -5) </details> ### 📄 Description - `X_DISPLAY_MISSING` was never set by anything and thus could never be true - `HAVE_DPMS_PROTOTYPES` was always true in the one instance where we checked for it - `HAVE_X11_EXTENSIONS_XTEST_H` caused a compiler error, moved to a cmake error now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>