platform and elsewhere #61

New issue

Closed

opened 2026-05-05 04:53:47 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 04:53:47 -06:00

Owner

Originally created by @p12tic on GitHub (Jul 1, 2018).
Original GitHub issue: https://github.com/debauchee/barrier/issues/76

Originally assigned to: @p12tic on GitHub.

I propose wrapping the platform interfaces in src/lib/platform and other places with wrapper classes and then only allowing calling the methods of these classes. This would give us the following benefits:

Whole Barrier could be mocked, which would allow to easily write tests to prevent regressions
We could have wrapper implementation which would log all calls. This would allow much easier diagnostics of any platform-specific bugs that can't be easily reproduced by the developers. The user could just enable the logging functionality, reproduce the bug, collect logs and send them along the bug report. This way it would be possible to investigate the bugs, fix them and write regression tests all without having access to the reproduction environment,

What do you think about this proposal?

Originally created by @p12tic on GitHub (Jul 1, 2018). Original GitHub issue: https://github.com/debauchee/barrier/issues/76 Originally assigned to: @p12tic on GitHub. I propose wrapping the platform interfaces in src/lib/platform and other places with wrapper classes and then only allowing calling the methods of these classes. This would give us the following benefits: - Whole Barrier could be mocked, which would allow to easily write tests to prevent regressions - We could have wrapper implementation which would log all calls. This would allow much easier diagnostics of any platform-specific bugs that can't be easily reproduced by the developers. The user could just enable the logging functionality, reproduce the bug, collect logs and send them along the bug report. This way it would be possible to investigate the bugs, fix them and write regression tests all without having access to the reproduction environment, What do you think about this proposal?